New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime.envFromFiles #3254

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@errordeveloper
Contributor

errordeveloper commented Dec 29, 2018

No description provided.

@GordonTheTurtle

This comment has been minimized.

Collaborator

GordonTheTurtle commented Dec 29, 2018

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:errordeveloper/linuxkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@errordeveloper errordeveloper force-pushed the errordeveloper:master branch 3 times, most recently from c5d746d to d45f905 Dec 29, 2018

@GordonTheTurtle GordonTheTurtle removed the dco/no label Dec 29, 2018

@errordeveloper errordeveloper force-pushed the errordeveloper:master branch 2 times, most recently from 38b563a to d0c0a07 Dec 29, 2018

@errordeveloper errordeveloper changed the title WIP: Add runtime.envFromFile Add runtime.envFromFile Dec 29, 2018

@errordeveloper errordeveloper force-pushed the errordeveloper:master branch from d0c0a07 to e6466c1 Dec 29, 2018

@errordeveloper errordeveloper force-pushed the errordeveloper:master branch from e6466c1 to 42044b3 Dec 29, 2018

@errordeveloper

This comment has been minimized.

Contributor

errordeveloper commented Dec 29, 2018

Just a few thoughts on my contributor experience, hopefully useful :)

@errordeveloper errordeveloper force-pushed the errordeveloper:master branch from 42044b3 to 7ea1129 Jan 2, 2019

Add runtime.envFromFiles
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>

@errordeveloper errordeveloper force-pushed the errordeveloper:master branch from 7ea1129 to b7268fa Jan 2, 2019

@errordeveloper

This comment has been minimized.

Contributor

errordeveloper commented Jan 2, 2019

@justincormack I've updated this. Let me know if you want me to open another PR with errordeveloper@3141cee.

@errordeveloper errordeveloper changed the title Add runtime.envFromFile Add runtime.envFromFiles Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment