Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add rsync in sshd package #3278
Please sign your commits following these rules:
$ git clone -b "sshd-rsync" email@example.com:errordeveloper/linuxkit.git somewhere $ cd somewhere $ git commit --amend -s --no-edit $ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Jan 27, 2019
I am not sure why CI gives me this error:
From previous experience, I recalled that I need to bump all uses of a package in the same PR/commit that introduces the changes to the package itself - does CI now assume that changes are made separately?
I'm not sure we want the
I'd suggest that either you can
Tough call. I tend to agree with this sentiment, but then why do we have the wireguard package installed (see here)?
I think this might be easier if there were a simple way for a consumer of
I just looked at the history; wireguard has been in since July 2017, when it was added to everything else. I don't recall the PR that added it, or the discussions around it, offhand. I do recall other discussions around adding more "standard" packages to getty and sshd, and usually they were held back to keep it minimal.
I would like to see none of it in there, and one of:
Either of these essentially comes down to some higher-order form of composition. We already have composition of layers and packages via
I am just not sure what that is, and if it is worth it...
Making it easier to fork a package without copying much of the config would be great. For example, sshd package has many binds, and wouldn't want to make a copy of those, I would rather add one or two on top. Perhaps we could add 'from' field in pkg config?