Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed fixed size arg from mkimage-gcp script. #3300

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@danrzs
Copy link

danrzs commented Mar 7, 2019

- What I did
Removed size arg from the tools/mkimage-gcp/make-gcp.sh script virt-make-fs command as this fixed size was failing with larger images.

- How I did it
delete key

- How to verify it
We have a large file included in our 'files:' directive, so this is where we found this issue. When making a large (>1GB) image with the old make-gcp script you'd get a "failed: exit code 1". We no longer get this error with the included change.

- Description for the changelog
Removed size arg from mkimage-gcp script.

- A picture of a cute animal (not mandatory but encouraged)
elephants

Removed size arg from GCP make-fs command.
The make-gcp script in the mkimage-gcp tool creates a virtual fs of 1GB, excactly. If your filesystem needs to be larger, then make-gcp errors in a poorly explained way. Simply removing the arg makes the fs the same size as the image used to build it.

Signed-off-by: Daniel Smith <daniel@razorsecure.com>
@justincormack

This comment has been minimized.

Copy link
Collaborator

justincormack commented Mar 7, 2019

I think the reason this is there is that GCP said (maybe it has changed?) that 1G was the minimum allowed size.

@danrzs

This comment has been minimized.

Copy link
Author

danrzs commented Mar 7, 2019

Interesting. I've made a smaller image that seems to have been bumped to 1GB by google, or maybe 1GB is just the smallest size it reports.

If you're worried about that being an issue, we can make it '--size=+1GB'* . A tad inefficient, but guarantees minimum size.

* - http://libguestfs.org/virt-make-fs.1.html - "For example: --size=+200M means enough space for the input files, and (approximately) an extra 200 MB free space."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.