Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 5.0.x kernels and update to 4.20.15/4.19.28 #3305

Merged
merged 11 commits into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@rn
Copy link
Member

rn commented Mar 10, 2019

Add support for building 5.x kernels and add 5.0.1/ 4.20.15/4.19.28 kernels

D1IaabhXcAAYnTS

rn added some commits Mar 10, 2019

kernel: Add support for building v5.x kernels
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
kernel: Support v5.x kernels in kconfig build
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
kernel: Remove fetch target
This target allowed to locally download the kernel source
tar balls. We haven't used this foir a while and adding
v5.x kernel support for it would add yet another conditional.

Remove it to keep the Makefile simpler.

Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
kernel: Add support for the v5.0.x kernel
The kernel config files are 4.20.x config files run through
make oldconfig for the 5.0 kernel.

Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
kernel: Update to 4.20.15/4.19.28
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
Updates YAMLs to latest kernels
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
tests: Add tests for the 5.0.x kernel
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
@rn

This comment has been minimized.

Copy link
Member Author

rn commented Mar 11, 2019

The kernel config test failed for 5.0.x with:

[+ 38m 09s] [STDERR  ] 2019-03-11T00:10:26.669505716Z: FAILURE: CONFIG_CC_STACKPROTECTOR_STRONG=y
[+ 38m 09s] [STDERR  ] 2019-03-11T00:10:26.669520043Z: FAILURE: CONFIG_DEBUG_RODATA=y
[+ 38m 09s] [STDERR  ] 2019-03-11T00:10:26.669533373Z: FAILURE: CONFIG_DEBUG_SET_MODULE_RONX=y
[+ 38m 09s] [STDERR  ] 2019-03-11T00:10:26.669568697Z: kernel config test failed!

rn added some commits Mar 17, 2019

tests: Adjust kernel config test for 5.x kernel
Many places where checking for -ge 4 and some minor version.
This will fail for 5.x kernels if their minor version is less.
Fix it.

While at it, also restructure/simplify the code, make it easier
to run against arbitrary kernel configs, and tidy up some
whitespaces.

Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
tests: Use latest moby kernel config test
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>

@rn rn force-pushed the rn:kern-up branch from a466374 to 500c79b Mar 17, 2019

rn added some commits Mar 17, 2019

tests: Skip Moby kernel config checks on 5.x
See moby/moby#38887
for details. Basically 5.x removed support for
CFQ with f382fb0bcef4 ("block: remove legacy IO
schedulers") and the Moby check still requires it.

Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
tests: Update kernel-config check image
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
@rn

This comment has been minimized.

Copy link
Member Author

rn commented Mar 17, 2019

@justincormack I had to chance the kernel config check script quite a bit, would be good to have another pair of eyes on that change.

Also had to disable the docker/moby kernel config check because CFQ is no longer in 5.x moby/moby#38887 (also see #3308 which I will pick up with the next update)

@justincormack

This comment has been minimized.

Copy link
Collaborator

justincormack commented Mar 18, 2019

Yeah the kernel checks are starting to look very ugly... maybe there is a better way. Will take a look at the moby check script, it looks like BFQ is fine.

@justincormack justincormack merged commit 26e8a72 into linuxkit:master Mar 18, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/datakit/linuxkit-ci All tests passed
Details
dco-signed All commits are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.