Permalink
Commits on Apr 23, 2018
  1. Spices.py: fix placement of docstrings (#7488)

    collinss authored and clefebvre committed Apr 23, 2018
  2. Added "shutdown immediately" entries for lid close and power critical. (

    Vanov authored and clefebvre committed Apr 23, 2018
  3. User applet: Fix compatibility with python3-pampy 1.8.2

    clefebvre committed Apr 23, 2018
    In 1.8.2, pam.authenticate() doesn't exist.
    
    Also make it clear in the output, which module is loaded,
    and make the deps less strict to allow Cinnamon to use either
    python3-pam (PAM) or python3-pampy (pam).
  4. User applet: Don't show switch-user when it's disabled in lockdown sc…

    clefebvre committed Apr 23, 2018
    …hema
    
    #7476
  5. Optimizr nextIndex in grid navigator (#7450)

    Connormiha authored and clefebvre committed Apr 23, 2018
    Fix codacy checks. Fix spaces
  6. Use for of for arrays (#7431)

    Connormiha authored and clefebvre committed Apr 23, 2018
  7. Applets, desklets: switch to class syntax, remove try-catch blocks (#…

    jaszhix authored and clefebvre committed Apr 23, 2018
    …7389)
    
    * Give xlet constructors unique names
    
    * calendar applet: switch to class syntax, fix class imports
    
    * a11y applet: switch to class syntax
    
    * expo applet: switch to class syntax
    
    * inhibit applet: switch to class syntax
    
    * keyboard applet: switch to class syntax, update constructor name
    
    * menu applet: switch to class syntax, fix SystemButton subclassing PopupSubMenuMenuItem and intializing PopupBaseMenuItem
    
    * notification applet: switch to class syntax
    
    * on-screen keyboard applet: switch to class syntax
    
    * panel launchers applet: switch to class syntax
    
    * power applet: switch to class syntax, remove un-used variables
    
    * recent applet: switch to class syntax, remove large try-catch block
    
    * removable drives applet: switch to class syntax, remove large try-catch block
    
    * scale applet: switch to class syntax
    
    * separator applet: switch to class syntax
    
    * setting example applet: switch to class syntax
    
    * settings applet: switch to class syntax, remove redundant try-catch block
    
    * show desklets applet: initialize with constructor instead
    
    * show desktop applet: initialize with constructor instead
    
    * slideshow applet: switch to class syntax, remove large try-catch block
    
    * sound applet: switch to class syntax, remove large try-catch block
    
    * space applet: switch to class syntax
    
    * systray applet: switch to class syntax
    
    * trash applet: switch to class syntax, remove redundant try-catch block
    
    * user applet: switch to class syntax, remove large try-catch block
    
    * window list applet: switch to class syntax
    
    * window quick-list applet: switch to class syntax, unwrap try-catch blocks, update formatting with prettier-eslint
    
    * workspace switcher applet: update class syntax, remove large try-catch block
    
    If cairo crashes, it could take down Cinnamon regardless of the JS
    context.
    
    * xrandr applet: switch to class syntax, remove large try-catch block, fix indentation
    
    * clock desklet: switch to class syntax, remove un-used variable
    
    * launcher desklet: switch to class syntax, clean up with prettier-eslint
    
    * photo frame desklet: switch to class syntax, remove large try-catch block, clean up with prettier-eslint
    
    * tooltips: allow TooltipBase to be subclassed for WindowPreview class in the window list applet
    
    * sound applet: Fix "reference to undefined property Symbol.toPrimitive"
    
    * Fix eslint issues, rebase conflict in sound applet
  8. Repaint node when background position changes (#7408)

    germanfr authored and clefebvre committed Apr 23, 2018
  9. Debugging: Add GObject property value logging (#7490)

    jaszhix authored and clefebvre committed Apr 23, 2018
  10. report paint volumes / don't use stage "paint" signal (#7478)

    itzexor authored and clefebvre committed Apr 23, 2018
    * cinnamon-global: Don't connect to the stage's paint signal
    
    This commit is a combination of the following commits from shell:
    
    071a4e5f83db6a0e0ab01a36110e7bf6bbbaca2c
    shell-global: Don't connect to the stage's paint signal
    
    Doing so causes useless full stage redraws and breaks culling
    as clutter cannot know how the signal handler affects painting.
    
    So use clutter_threads_add_repaint_func_full instead.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=694988
    
    -----------------------------------------------------------------------
    
    95ec8ef5e16d9f5df800802d444d0c2eebe9c89b
    shell-global: Fix regression from 071a4e5f83db6a0e0ab01a3
    
    The clutter_threads_add_repaint_func_full need to return TRUE otherwise
    they will be only called once.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=695006
    
    * cinnamon-generic-container: Exclude skip_paint actors from paint volume
    
    from gnome-shell 37595ff3e72ad618:
    
    We are not painting them so there is no reason to redraw a bigger
    area because of them.
  11. Sync the logic in cs_startup with cinnamon-session (#7463)

    maxyz authored and clefebvre committed Apr 23, 2018
    * Also show the GNOME autostart desktop files
    
    Match the autostart desktop files logic to the on in cinnamon-session,
    otherwise only a small subset of the autostart files are being listed.
    
    * Blacklist the desktop files blacklisted in cinnamon-session
    
    * Don't use the system location by default
    
    Using the system desktop file as the base for the new one, losses any
    changes the user might have done to the desktop file.
    
    * Typo, store the dirname in the dir attribute
  12. date applet - add option to theme calendar menu separately from other…

    smurphos authored and clefebvre committed Apr 23, 2018
    … applet menus (#7415)
    
    * calendar applet - add option to theme menu seperately from other applet menus
    
    * calendar applet - fix spelling typo in comment
  13. default theme - add .menu-background{} as placeholder (#7416)

    smurphos authored and clefebvre committed Apr 23, 2018
    * default theme - add .menu-background{} as placeholder
    
    * default theme - amend comment - spices menu applets also use menu_background style_class
  14. SettingsWidgets.py: TextView widget - fix focus-stealing bug (#7377)

    collinss authored and clefebvre committed Apr 23, 2018
  15. Spices.py: Initiate monitor variable

    clefebvre committed Apr 23, 2018
  16. Add a script to install 3rd party spices from a local folder. This is… (

    collinss authored and clefebvre committed Apr 23, 2018
    #7420)
    
    * Add a script to install 3rd party spices from a local folder. This is meant to be a helper script to aid in applet development.
    
    * Spices.py: only show an update if the current version is less than the available one
    
    * cinnamon-install-spice: fix typo
    
    * Add argument parsing and usage to the xlet install script, and fix some bugs
  17. Workspace switcher: fix buttons sizing (#7495)

    germanfr authored and clefebvre committed Apr 23, 2018
    * In vertical panels, the width wasn't the full panel width as it
       does in horizontal mode and every applet does in vertical mode.
    
     * In horizontal panels, if a width wasn't defined in CSS the
       labels were hidden because they ellipsized to zero width.
    
     * Updated default theme to still look the same as it did.
  18. PopupMenu.js: Use some lambdas to create half the functions on each a…

    germanfr authored and clefebvre committed Apr 23, 2018
    …ction (#7493)
    
    * PopupMenu.js: Use some lambdas to create half the functions on each action
    
    This also avoids calling functions that call functions in some
    cases and improves readability.
    
    * popupMenu.js: avoid using filter + map that created two arrays
  19. Fix JS exporter parsing (#7477)

    germanfr authored and clefebvre committed Apr 23, 2018
    * Fix exported variable/functions regex. It didn't recognize
       variables with numbers in the name.
    
     * Fix module.exports recognition regex and remove clutter. It only
       recognized some exported variable names, but not numbers nor objects,
       and it required a space before and after the assignment token (=).
    
     * Add a new line character after the prepended 'use strict' or otherwise
       the parser won't recognize exported variables in the first line.
    
     * Use test instead of match because it's faster in this use case. It only
       checks until the first occurrence and doesn't generate strings like match.
  20. Hot corners cleanup and fixes (#7442)

    germanfr authored and clefebvre committed Apr 23, 2018
    * Remove hot corners toggle desktop warning
    
    global.get_current_time() returns 0 when called from outside an event handler.
    The timer is outside the event handler.
    
    * Replace deprecated function clutter_actor_set_pivot_point()
    
    * Remove remains of the old hot corners buttons
    
     * Use ClutterActor instead of ClutterGroup (deprecated)
     * Remove unused import: tooltips
    
    * Show hot corners in primary monitor only
    
    * Use logError instead of normal log to log an error
    
    * cs_hotcorner: Update interface and remove deprecations
    
     * Some options and strings no longer made sense
     * Widgets had no margins between them
     * And they used deprecated methods and widgets
    
    * cs_hotcorner: Update display view
    
     * Also properly draw corner circles, some where bigger or stretched 1px
     * Remove context save/restore, it's not needed.
  21. Sound applet: make optional horizontal scroll to move between tracks (#…

    germanfr authored and clefebvre committed Apr 23, 2018
    …7407)
    
    
    Fixes #7400
  22. Fix top panel overlapping the on-screen keyboard (#7398)

    germanfr authored and clefebvre committed Apr 23, 2018
    * Add some padding to the OSK so that the top panel doesn't overlap it.
     * Also better calculate paddings to avoid a layout overflow.
     * Add a missing else.
  23. Default menu - fix unused selector .menu-category-button-button (#7393)

    smurphos authored and clefebvre committed Apr 23, 2018
    * Default menu - fix unused selector .menu-category-button-button
    
    * Remove themeing from .menu-category-button-selected:hover
  24. menu applet - if no selected item when adding search provider results…

    smurphos authored and clefebvre committed Apr 23, 2018
    … make first search provider result selected item (#7414)
    
    * menu applet - add any search_provider results before making first result selected item
    
    * Menu - check for null this._selectedItemIndex and correct when adding search provider results
    
    * Menu - clean-up whitespace
    
    * Menu - clean-up whitespace take 2
    
    * Menu - clean-up whitespace take 3
  25. [Spices.py] Added missing import, fixed typo and removed unnecessary …

    Odyseus authored and clefebvre committed Apr 23, 2018
    …semicolons (#7459)
    
    - Inside the `Spice_Harvester` class initialization code the `dbus.exceptions.DBusException` exception was used, but the **dbus** module wasn't imported.
    - The `disconnect_proxy` method of the `Spice_Harvester` class had what seemed to be a typo (**please, triple check this**).
    - The `enable_extension` method of the `Spice_Harvester` class had several lines ending with semicolon.
  26. Use ints for the menu position (#7449)

    maxyz authored and clefebvre committed Apr 23, 2018
    In python3 the / operator returns floats, to maintain the previous behaviour
    we need to use the // operator.
  27. PEP8ify (#7448)

    maxyz authored and clefebvre committed Apr 23, 2018
    Update scripts to match the pep8 guidelines
    (https://www.python.org/dev/peps/pep-0008)
    
     - multiple imports in the same line
     - module level import not at top of file
     - bare except used: this is dangerous and should be avoided
     - missing whitespace around arithmetic operator
     - expected 2 blank lines after class or function definition, found 1
     - continuation line under-indented for visual indent
     - local variable is assigned to but never used
  28. Fix blurry st scrollbars (#7498)

    germanfr authored and clefebvre committed Apr 23, 2018
    Positions must be integers.
  29. user-applet: use symbolic icon from themes (#7494)

    NikoKrause authored and clefebvre committed Apr 23, 2018
    all symbolics used are available in the Adwaita icon theme
Commits on Apr 20, 2018
  1. Modal dialog: don't stretch icon, align it to the top (#7397)

    germanfr authored and clefebvre committed Apr 20, 2018
  2. Melange: slight UI rework (#7424)

    itzexor authored and clefebvre committed Apr 20, 2018
    * Melange: slight UI reworks
    
    Main window:
     - Adds a garbage collect button next to the inspect button. This is
       also on the currently disabled memory tab.
    
     - Removes description labels and adds tooltips instead
    
     - Uses nicer keybind display format
    
    Inspect tab:
     - Back button is now always enabled. When the inspection stack is
       empty then the Results tab is activated.
    
    * lookingGlass.js: result tooltip improvements
    
     - Eval result: sub-millisecond precision for execution time
    
     - Inspection result: generic tooltip so it's not blank
  3. PEP8ify (#7434)

    maxyz authored and clefebvre committed Apr 20, 2018
    Update scripts to match the pep8 guidelines
    (https://www.python.org/dev/peps/pep-0008)
    
     - multiple imports in the same line
     - module level import not at top of file
     - polib imported but unused
     - gi imported but unused
     - bare except used: this is dangerous and should be avoided
  4. sound@cinnamon.org applet - Solves issue #7375 (#7376)

    claudiux authored and clefebvre committed Apr 20, 2018
    * sound@cinnamon.org applet - Solves issue #7375
    
    * Fixes step of slider scrolling to 5% of nominal volume instead of 5% of maximal volume
    
    * Makes the '100%' mark really magnetic, adapting the sound volume.
    
    * Removed empty lines
  5. Window list applet: fix bad allocation of icons and labels (#7386)

    germanfr authored and clefebvre committed Apr 20, 2018
    * Place icon and label according to their parent borders and paddings
       (aka don't draw these over the borders).
     * Use correct spacing of elements.
     * Update default theme and remove unused class.
  6. System settings: Don't crash when failing to set up file monitors

    clefebvre committed Apr 20, 2018