Permalink
Commits on Aug 16, 2018
  1. deskletManager: Fix launcher-list gsetting resetting on desklet snap …

    jaszhix authored and mtwebster committed Jul 8, 2018
    …grid width change
  2. power applet: Don't attempt to send csd-power a brightness over 100%.

    mtwebster committed Aug 16, 2018
    This causes the call to be rejected, and the slider will end up jumping
    back to the previous step value.  This occurs because we restrict the
    minimum brightness to .01 (1%) which can cause the slider (due to the
    stepping) to try to hit 101%.
Commits on Aug 10, 2018
  1. power applet: override scroll handler for the brightness sliders, to …

    mtwebster committed Aug 10, 2018
    …use the
    
    step value obtained from csd-power (if available.)
  2. power applet/settings: Lock keyboard backlight changes to only valid

    mtwebster committed Aug 10, 2018
    increments.
    
    Needs linuxmint/cinnamon-settings-daemon@717d50d to work properly
    (though it should work acceptably without)
Commits on Aug 9, 2018
  1. cs_power.py: Align the new peripheral battery status at the end of th…

    mtwebster committed Aug 9, 2018
    …e row, and do
    
    the same for the charge status of battery devices for consistency.
  2. power: Show primitive battery level for devices that don't support pe…

    mtwebster committed Jun 9, 2018
    …rcentages.
    
    (requires change to csd-power)
Commits on Jul 30, 2018
  1. popupMenu: Fix undefined _delegate property warning (#7706)

    jaszhix authored and clefebvre committed Jul 30, 2018
    Cjs-Message: 03:25:55.954: JS WARNING:
    [/usr/share/cinnamon/js/ui/popupMenu.js 2048]: reference to undefined
    property "_delegate"
  2. Translation for "Users and Groups" policy (#7763)

    NikoKrause authored and clefebvre committed Jul 30, 2018
Commits on Jul 28, 2018
  1. menu applet: Make sure the menu is fully reset when the search entry

    mtwebster committed Jul 28, 2018
    is cleared (thru any means) and don't let the favorites Del key handler
    steal keystrokes from an active search.
    
    this.lastSelectedCategory is initialized to null.  Set our category to
    a dummy 'search' when a search begins, so _select_category(null)
    completes properly when the search is cleared, instead of comparing null
    and returning early.
    
    Fixes #7764
Commits on Jul 22, 2018
  1. cs_themes.py: Add xdg user data dir to theme search paths, search

    mtwebster committed Jul 22, 2018
    all system data dirs.  This corresponds to the same behavior as code
    that actually loads these themes in Gtk, Cinnamon.
    
    Refactor themeManager.js slightly to search the user data dir first,
    before checking the remaining ones.
    
    Fixes #7761
Commits on Jul 18, 2018
  1. cs_sound.py: Gracefully handle input streams that don't have a name,

    mtwebster committed Jul 18, 2018
    ignore streams created by sound effects and a11y utilities, and don't
    add the same source id more than once.
Commits on Jul 17, 2018
  1. 3.8.8

    clefebvre committed Jul 17, 2018
Commits on Jul 11, 2018
  1. network applet: Initialize CinnamonNetworkApplet._updateFrequencySeconds

    mtwebster committed Jul 11, 2018
    before using in _periodicUpdateIcon.
Commits on Jul 5, 2018
  1. 3.8.7

    clefebvre committed Jul 5, 2018
Commits on Jul 2, 2018
  1. cinnamon-settings-users.py: fix symlink attack vulnerability

    mgerstner authored and mtwebster committed Jun 28, 2018
    This script runs as root and allows to configure e.g. other user's icon
    files. These icon files are written to the respective user's $HOME/.face
    location. If an unprivileged user prepares a symlink pointing to an
    arbitrary location then this location will be overwritten with the icon
    content. This vulnerability thus allows to corrupt the system or other
    user's files. The content is not attacker controlled, luckily.
    
    This change introduces temporary privilege drops to the target user's
    privileges before attempting to write the respective .face files. This
    way the kernel can decide if permissions are okay or not.
Commits on Jun 27, 2018
  1. spices: Remove support for installing/removing system-wide gsettings

    mtwebster committed Jun 27, 2018
    schemas.
    
    Only 3 applets required this, and they've been removed or ported to
    use xlet settings.
Commits on Jun 24, 2018
  1. 3.8.6

    clefebvre committed Jun 24, 2018
  2. Revert "network applet: show the actual active connection's signal st…

    clefebvre committed Jun 24, 2018
    …rength"
    
    This reverts commit 319958f.
    
    The commit caused a regression on some machines. After a few hours,
    the signal strengh (both in the menu and the panel) dropped to 0% and
    stayed there forever.
    
    Reverting the commit fixes that.
  3. Revert "network applet: Fix typo with showing access points in certai…

    clefebvre committed Jun 24, 2018
    …n instances -"
    
    This reverts commit 2183ab5.
Commits on Jun 22, 2018
  1. 3.8.5

    clefebvre committed Jun 22, 2018
  2. Revert "shell-embedded-window: change realize to map (#6965)"

    clefebvre committed Jun 22, 2018
    This reverts commit fa9a5c7.
    
    This commit created a regression in the default systray applet:
    
    - When the panel was set to autohide or hide intelligently,
    after it hid itself once, systray icons would no longer
    update.
    
    - This could be reproduced with a right-click->refresh on
    mintupdate and an auto-hidden panel.
    
    Reverting this commit fixed this issue.
Commits on Jun 17, 2018
  1. cs_windows.py: have the 'auto-raise' setting only visible when

    mtwebster committed Jun 17, 2018
    supported focus modes are active.
    
    This setting has no effect in 'click' mode, the default, whereas
    it's totally obvious what it does in the other two modes.
  2. Update po/README: provide a link to Launchpad (#7655)

    dhgutteridge authored and clefebvre committed Jun 17, 2018
    Provide a link to Launchpad, since I see potential contributors are often using GitHub as their starting point, and trying to submit translation corrections via GitHub rather than Launchpad.
Commits on Jun 8, 2018
  1. 3.8.4

    clefebvre committed Jun 8, 2018
  2. l10n: Update POT file

    clefebvre committed Jun 8, 2018
  3. cs_power.py: Display a keyboard backlight section on the brightness (#…

    mtwebster authored and clefebvre committed Jun 8, 2018
    …7621)
    
    tab if it's found (and only if there's a brightness section.)
  4. Revert "network applet: Don't show unmanaged networks in the list."

    clefebvre committed Jun 8, 2018
    This reverts commit 3e366ce.
    
    This commit resulted in wireless devices not showing up in the applet
    even though they were manageable and visible in CCC.
    
    Although the commit properly hid unmanageable devices, it also stopped
    the applet from listening to signal changes on them.
    
    If a device was unmanageable when added and then manageable then-after
    the applet wouldn't hear the signal change and the device wouldn't
    show up in the menu.
    
    This is reproducible on a Macbook Pro with:
    
    sudo rmmod wl
    sudo modprobe wl
    
    When the driver comes back, the menu should rebuild and list the wireless APs.
    This commit prevented that.
Commits on Jun 7, 2018
  1. systray: Fix skype

    clefebvre committed Jun 7, 2018
    Skype 8.22.0.2 seems to provide an icon which contains multiple versions of itself.
    It only looks OK in 16x16px.
  2. cs_power.py: Eliminate redundant check for screen backlight. It

    mtwebster committed Jun 7, 2018
    fails incorrectly.
    
    Error checking GetPercentage on the Screen interface seems to be more
    reliable.
Commits on Jun 6, 2018
  1. network applet: Fix typo with showing access points in certain instan…

    mtwebster committed Jun 6, 2018
    …ces -
    
    caused by 319958f
Commits on Jun 5, 2018
  1. tooltips.js: use ClutterActor's has-pointer property for timeout

    mtwebster committed Jun 5, 2018
    callback check.
    
    This seems to resolve occasional stuck tooltips in the window list
    applet's preview implementation.
Commits on May 29, 2018
  1. st-theme-node-drawing,transition.c: initialize framebuffer early to

    mtwebster committed May 29, 2018
    check for error.
    
    Based on: https://bugzilla.redhat.com/show_bug.cgi?id=1349959 and
    associated patch.
    
    Associated partial trace:
    0  0x00007f65d6ac1c41 in _g_log_abort (breakpoint=1) at ../../../../glib/gmessages.c:583
    1  0x00007f65d6ac2c7c in g_log_default_handler (log_domain=log_domain@entry=0x7f65d475ed6d "Cogl", log_level=log_level@entry=6, message=message@entry=0x5593b14a7f30 "Failed to create an OpenGL framebuffer object", unused_data=unused_data@entry=0x0) at ../../../../glib/gmessages.c:3158
    2  0x00007f65d6ac2f0d in g_logv (log_domain=log_domain@entry=0x7f65d475ed6d "Cogl", log_level=log_level@entry=G_LOG_LEVEL_ERROR, format=<optimized out>, args=<optimized out>) at ../../../../glib/gmessages.c:1370
    3  0x00007f65d474d199 in _cogl_set_error (error=error@entry=0x0, domain=<optimized out>, code=code@entry=0, format=format@entry=0x7f65d475f7c8 "Failed to create an OpenGL framebuffer object") at cogl-error.c:83
    4  0x00007f65d46fc99a in _cogl_offscreen_gl_allocate (offscreen=0x5593af4833e0, error=0x0) at driver/gl/cogl-framebuffer-gl.c:953
    5  0x00007f65d4743335 in cogl_framebuffer_allocate (framebuffer=framebuffer@entry=0x5593af4833e0, error=error@entry=0x0) at cogl-framebuffer.c:798
    6  0x00007f65d46fc02f in _cogl_framebuffer_gl_flush_state (draw_buffer=0x5593af4833e0, read_buffer=0x5593af4833e0, state=(COGL_FRAMEBUFFER_STATE_BIND | COGL_FRAMEBUFFER_STATE_VIEWPORT | COGL_FRAMEBUFFER_STATE_CLIP | COGL_FRAMEBUFFER_STATE_DITHER | COGL_FRAMEBUFFER_STATE_MODELVIEW | COGL_FRAMEBUFFER_STATE_PROJECTION | COGL_FRAMEBUFFER_STATE_COLOR_MASK | COGL_FRAMEBUFFER_STATE_FRONT_FACE_WINDING | COGL_FRAMEBUFFER_STATE_DEPTH_WRITE | COGL_FRAMEBUFFER_STATE_STEREO_MODE)) at driver/gl/cogl-framebuffer-gl.c:390
    7  0x00007f65d4743738 in cogl_framebuffer_clear4f (framebuffer=framebuffer@entry=0x5593af4833e0, buffers=buffers@entry=1, red=red@entry=0, green=green@entry=0, blue=blue@entry=0, alpha=alpha@entry=0) at cogl-framebuffer.c:385
    8  0x00007f65d818daca in st_theme_node_render_resources (height=27, width=1680, node=0x5593b1862870 [StThemeNode]) at st/st-theme-node-drawing.c:1478
    9  0x00007f65d818daca in st_theme_node_paint (node=node@entry=0x5593b1862870 [StThemeNode], fb=0x5593af3fa9b0, box=box@entry=0x7ffd417961a0, paint_opacity=paint_opacity@entry=255 '\377') at st/st-theme-node-drawing.c:2005
    10 0x00007f65d8191277 in st_widget_paint_background (widget=0x5593b0c3db10 [CinnamonGenericContainer]) at st/st-widget.c:385
    11 0x00007f65d815aee1 in cinnamon_generic_container_paint (actor=0x5593b0c3db10 [CinnamonGenericContainer]) at cinnamon-generic-container.c:130
    
    Seemed to manifest for me when switching to tty when using multiple monitors (intel but with nvidia prime)
Commits on May 28, 2018
  1. SettingsWidgets.py: strip pkexec from standalone module exec strings

    mtwebster committed May 28, 2018
    when checking for their existence.  Simplify the check as well.
    
    Fixes linuxmint/cinnamon-control-center#208