Permalink
Commits on Jun 17, 2018
  1. cs_windows.py: have the 'auto-raise' setting only visible when

    mtwebster committed Jun 17, 2018
    supported focus modes are active.
    
    This setting has no effect in 'click' mode, the default, whereas
    it's totally obvious what it does in the other two modes.
  2. Update po/README: provide a link to Launchpad (#7655)

    dhgutteridge authored and clefebvre committed Jun 17, 2018
    Provide a link to Launchpad, since I see potential contributors are often using GitHub as their starting point, and trying to submit translation corrections via GitHub rather than Launchpad.
Commits on Jun 8, 2018
  1. 3.8.4

    clefebvre committed Jun 8, 2018
  2. l10n: Update POT file

    clefebvre committed Jun 8, 2018
  3. cs_power.py: Display a keyboard backlight section on the brightness (#…

    mtwebster authored and clefebvre committed Jun 8, 2018
    …7621)
    
    tab if it's found (and only if there's a brightness section.)
  4. Revert "network applet: Don't show unmanaged networks in the list."

    clefebvre committed Jun 8, 2018
    This reverts commit 3e366ce.
    
    This commit resulted in wireless devices not showing up in the applet
    even though they were manageable and visible in CCC.
    
    Although the commit properly hid unmanageable devices, it also stopped
    the applet from listening to signal changes on them.
    
    If a device was unmanageable when added and then manageable then-after
    the applet wouldn't hear the signal change and the device wouldn't
    show up in the menu.
    
    This is reproducible on a Macbook Pro with:
    
    sudo rmmod wl
    sudo modprobe wl
    
    When the driver comes back, the menu should rebuild and list the wireless APs.
    This commit prevented that.
Commits on Jun 7, 2018
  1. systray: Fix skype

    clefebvre committed Jun 7, 2018
    Skype 8.22.0.2 seems to provide an icon which contains multiple versions of itself.
    It only looks OK in 16x16px.
  2. cs_power.py: Eliminate redundant check for screen backlight. It

    mtwebster committed Jun 7, 2018
    fails incorrectly.
    
    Error checking GetPercentage on the Screen interface seems to be more
    reliable.
Commits on Jun 6, 2018
  1. network applet: Fix typo with showing access points in certain instan…

    mtwebster committed Jun 6, 2018
    …ces -
    
    caused by 319958f
Commits on Jun 5, 2018
  1. tooltips.js: use ClutterActor's has-pointer property for timeout

    mtwebster committed Jun 5, 2018
    callback check.
    
    This seems to resolve occasional stuck tooltips in the window list
    applet's preview implementation.
Commits on May 29, 2018
  1. st-theme-node-drawing,transition.c: initialize framebuffer early to

    mtwebster committed May 29, 2018
    check for error.
    
    Based on: https://bugzilla.redhat.com/show_bug.cgi?id=1349959 and
    associated patch.
    
    Associated partial trace:
    0  0x00007f65d6ac1c41 in _g_log_abort (breakpoint=1) at ../../../../glib/gmessages.c:583
    1  0x00007f65d6ac2c7c in g_log_default_handler (log_domain=log_domain@entry=0x7f65d475ed6d "Cogl", log_level=log_level@entry=6, message=message@entry=0x5593b14a7f30 "Failed to create an OpenGL framebuffer object", unused_data=unused_data@entry=0x0) at ../../../../glib/gmessages.c:3158
    2  0x00007f65d6ac2f0d in g_logv (log_domain=log_domain@entry=0x7f65d475ed6d "Cogl", log_level=log_level@entry=G_LOG_LEVEL_ERROR, format=<optimized out>, args=<optimized out>) at ../../../../glib/gmessages.c:1370
    3  0x00007f65d474d199 in _cogl_set_error (error=error@entry=0x0, domain=<optimized out>, code=code@entry=0, format=format@entry=0x7f65d475f7c8 "Failed to create an OpenGL framebuffer object") at cogl-error.c:83
    4  0x00007f65d46fc99a in _cogl_offscreen_gl_allocate (offscreen=0x5593af4833e0, error=0x0) at driver/gl/cogl-framebuffer-gl.c:953
    5  0x00007f65d4743335 in cogl_framebuffer_allocate (framebuffer=framebuffer@entry=0x5593af4833e0, error=error@entry=0x0) at cogl-framebuffer.c:798
    6  0x00007f65d46fc02f in _cogl_framebuffer_gl_flush_state (draw_buffer=0x5593af4833e0, read_buffer=0x5593af4833e0, state=(COGL_FRAMEBUFFER_STATE_BIND | COGL_FRAMEBUFFER_STATE_VIEWPORT | COGL_FRAMEBUFFER_STATE_CLIP | COGL_FRAMEBUFFER_STATE_DITHER | COGL_FRAMEBUFFER_STATE_MODELVIEW | COGL_FRAMEBUFFER_STATE_PROJECTION | COGL_FRAMEBUFFER_STATE_COLOR_MASK | COGL_FRAMEBUFFER_STATE_FRONT_FACE_WINDING | COGL_FRAMEBUFFER_STATE_DEPTH_WRITE | COGL_FRAMEBUFFER_STATE_STEREO_MODE)) at driver/gl/cogl-framebuffer-gl.c:390
    7  0x00007f65d4743738 in cogl_framebuffer_clear4f (framebuffer=framebuffer@entry=0x5593af4833e0, buffers=buffers@entry=1, red=red@entry=0, green=green@entry=0, blue=blue@entry=0, alpha=alpha@entry=0) at cogl-framebuffer.c:385
    8  0x00007f65d818daca in st_theme_node_render_resources (height=27, width=1680, node=0x5593b1862870 [StThemeNode]) at st/st-theme-node-drawing.c:1478
    9  0x00007f65d818daca in st_theme_node_paint (node=node@entry=0x5593b1862870 [StThemeNode], fb=0x5593af3fa9b0, box=box@entry=0x7ffd417961a0, paint_opacity=paint_opacity@entry=255 '\377') at st/st-theme-node-drawing.c:2005
    10 0x00007f65d8191277 in st_widget_paint_background (widget=0x5593b0c3db10 [CinnamonGenericContainer]) at st/st-widget.c:385
    11 0x00007f65d815aee1 in cinnamon_generic_container_paint (actor=0x5593b0c3db10 [CinnamonGenericContainer]) at cinnamon-generic-container.c:130
    
    Seemed to manifest for me when switching to tty when using multiple monitors (intel but with nvidia prime)
Commits on May 28, 2018
  1. SettingsWidgets.py: strip pkexec from standalone module exec strings

    mtwebster committed May 28, 2018
    when checking for their existence.  Simplify the check as well.
    
    Fixes linuxmint/cinnamon-control-center#208
Commits on May 21, 2018
  1. 3.8.3

    clefebvre committed May 21, 2018
  2. extension: Fix inability to force xlet installs (#7571)

    jaszhix authored and clefebvre committed May 21, 2018
  3. cs_startup.py: Always have delay widgets, but hide/show them depending

    mtwebster committed May 21, 2018
    on if there's a delay or not.
Commits on May 17, 2018
  1. Settings: Fix launching mintsources/mintdrivers/lightdm-settings

    clefebvre committed May 17, 2018
    These apps now require pkexec
Commits on May 9, 2018
  1. Cinnamon theme: window-list progress improvements (#7562)

    NikoKrause authored and clefebvre committed May 9, 2018
    use border radius for progress
    use border-radius dependent on top/right/left panel for window-list-box
    
    grey progress (instead of red)
  2. fix symbolic icons and delete obsolete (#7566)

    NikoKrause authored and clefebvre committed May 9, 2018
    cs-backgrounds-symbolic and cs-desklets-symbolic just showed a grey square, because there was an invisible square hidden in these icons.
    
    delete the 16px non-symbolic-icon versions of these icons, they are replaced by the symbolics no icons, they are replaced by the symbolics now
  3. Use default icon names in Online Accounts (GOA) (#7559)

    NikoKrause authored and clefebvre committed May 9, 2018
    and fix icon size to 22
Commits on May 6, 2018
  1. 3.8.2

    clefebvre committed May 6, 2018
  2. l10n: Update POT file

    clefebvre committed May 6, 2018
  3. chrome: Improve visibility conditions for panels and other chrome (#7552

    mtwebster authored and clefebvre committed May 6, 2018
    )
    
    when windows are fullscreen and popups or menus are activated.
    
    Intended behavior:
    
    Single monitor setups: Panels are hidden only when a given fullscreen
    window for a given monitor actually is the toplevel window for that
    monitor.  If a popup is activate (like the Cinnamon menu via shortcut,)
    the panels will show while that modal is active.  This prevents a
    weird disembodied menu popping out of nowhere.  Further, if a non-
    fullscreen window is alt-tabbed to, or otherwise made the focus, the
    panels will also return until the fullscreen window is re-focused.
    
    Multi-monitor setups: Same as single monitor, except for modal actor
    behavior is different - only the panel(s) on the monitor which currently
    hosts the last-added/current modal actor are shown.  This allows, for
    instance, the alt-tab popup or menu to be used on your 'work' monitor
    without disrupting the view of your 'movie/tv-show' monitor.
    
    Requires muffin patch as well: linuxmint/muffin#317
  4. Notification close policy (#7531)

    germanfr authored and clefebvre committed May 6, 2018
    * Do not close notification when the mouse is over it
    
    Very often, the notification closes just before clicking on it.
    
    * Fix don't close notification when moving towards it
    
    It no longer makes sense to see if the y coordinate increases/decreases
    because the notification can be at the top and at the bottom.
    Now we work with distances.
  5. fileUtils: Fix module exporter bug, fix line numbers in stack traces …

    jaszhix authored and clefebvre committed May 6, 2018
    …being incorrect (#7553)
    
    * Fix module exports in cases where module.exports is de-referenced from exports
    
    * Fix line numbers in stack traces being off by one, fix original regex issue of first variable on line 1 being ignored
  6. Minor lang changes (#7554)

    WKFO authored and clefebvre committed May 6, 2018
  7. Fix some issues with the download refactoring in Spices.py (#7549)

    collinss authored and clefebvre committed May 6, 2018
    * Spices.py: use `with lock` instead of `lock.acquire` to ensure a lock always gets removed
    
    * Spices.py: updaate progress: only use the total downloads to calculate the fraction when there is more than one
    This prevents a divide-by-zero under certain circumstances, and gives more meaningfull progress information.
    
    * Spices.py: add a timeout to urlopen to prevent a hang when the connection is interrupted mid-download
    
    * Spices.py: don't open a file stream until we're ready, and use the with operator to ensure that we don't leak file descriptors
  8. popupMenu: fix menu cutoff during open/close animation (#7547)

    germanfr authored and clefebvre committed May 6, 2018
    When using margins on the menu it is shifted a bit and the clip
    doesn't end just in the panel. This is fixed by taking margins
    into account for the end/start positions and the clip size.
    
    For some reason, sometimes margins must be subtracted twice.
    There is no math here, only trial and error. I haven't found
    any logical behavior, only that actors are automatically
    shifted when they have margins.
    
    For example:
    actor.x = actor.x - actor.margin_left  // Does nothing
    actor.x = actor.x - actor.margin_left * 2  // Shifts margin ok
    actor.x = actor.x  // Shifts actor to the right
  9. debian/control: increase deps version of muffin, cjs and cinnamon-des…

    Fantu authored and clefebvre committed Apr 25, 2018
    …ktop
    
    make them strict in packages to avoid unexpected cases
    build-deps instead increased to latest (is not possible use ${cinnamon:Version}
    on it)
Commits on May 5, 2018
  1. Spices.py: Handle the cinnamon proxy better regardless of whether

    mtwebster committed May 5, 2018
    cinnamon is running or not.
    
    The proxy may be created without issue, even if org.Cinnamon isn't
    actually available, so we need to check for a name-owner when making
    calls to it.  We can use RunStateChanged to observe when cinnamon
    starts, and call our deferred calls in that case.
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1574369
  2. Spices.py: fix file permissions durring install

    collinss authored and mtwebster committed May 4, 2018
    Because the files are zipped, and then unziped, the execute bit is getting lost when xlets are installed through cinnamon-settings, which in turn causes certain included scripts to not run. This sets the permissions manually on all files to ensure that everything has the necessary permissions.
  3. Spices.py: refactor downloading code for better error handling

    collinss authored and mtwebster committed Apr 30, 2018
  4. Fix window list previews position

    germanfr authored and mtwebster committed May 1, 2018
     * There was no margin the first time it showed up because the position
       was set before actually showing the actor.
    
     * Update position when window size changes, notably when bottom-positioned.
  5. menu applet: Wrong parent class for SystemButton (fixes focus stealing

    mtwebster committed May 5, 2018
    when hovering over system buttons.)
    
    Fixes #7515