Add exception for files/Makefile.in in .gitignore file. #1322

Closed
vladimir-didenko opened this Issue Nov 1, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@vladimir-didenko

.gitignore file has 'Makefile.in' rule that matches files/Makefile.in . But files/Makefile.in is necessary for building so I think rule that makes exception for files/Makefile.in should be added.

@AlbertJP

This comment has been minimized.

Show comment Hide comment
@AlbertJP

AlbertJP Nov 2, 2012

Member

@vovka-korovka Should I change it into ./Makefile.in ?

Member

AlbertJP commented Nov 2, 2012

@vovka-korovka Should I change it into ./Makefile.in ?

@vladimir-didenko

This comment has been minimized.

Show comment Hide comment
@vladimir-didenko

vladimir-didenko Nov 6, 2012

You just should apply follow simple change for .gitignore file

diff --git a/.gitignore b/.gitignore
index fa5927a..44680f8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
ABOUT-NLS
Makefile.in
+!files/Makefile.in
aclocal.m4
browser-plugin/Makefile.in
config.h.in

You just should apply follow simple change for .gitignore file

diff --git a/.gitignore b/.gitignore
index fa5927a..44680f8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
ABOUT-NLS
Makefile.in
+!files/Makefile.in
aclocal.m4
browser-plugin/Makefile.in
config.h.in

@AlbertJP

This comment has been minimized.

Show comment Hide comment
@AlbertJP

AlbertJP Nov 6, 2012

Member

@vovka-korovka Normally I would have asked you to make a pull request, but now I'll commit it myself since it may have to be done quickly to get into 1.6 series.

Member

AlbertJP commented Nov 6, 2012

@vovka-korovka Normally I would have asked you to make a pull request, but now I'll commit it myself since it may have to be done quickly to get into 1.6 series.

@vladimir-didenko

This comment has been minimized.

Show comment Hide comment
@vladimir-didenko

vladimir-didenko Nov 6, 2012

Sorry, will create pull requests in future.

Sorry, will create pull requests in future.

@AlbertJP

This comment has been minimized.

Show comment Hide comment
@AlbertJP

AlbertJP Nov 6, 2012

Member

Thanks for your help anyway.

Member

AlbertJP commented Nov 6, 2012

Thanks for your help anyway.

@clefebvre clefebvre closed this Dec 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment