Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze after Clearing Notifications #1490

Closed
tsujan opened this issue Dec 11, 2012 · 9 comments
Closed

Freeze after Clearing Notifications #1490

tsujan opened this issue Dec 11, 2012 · 9 comments

Comments

@tsujan
Copy link

tsujan commented Dec 11, 2012

Sometimes, when all notifications are cleared manually, the screen freezes completely so that only the hard reset could be used. Because of the hard reset, I can't provide you with any error message or log file. That happened to me two times in two weeks. I use Cinnamon 1.6.7 on Debian with nvidia 304.64.

@tsujan
Copy link
Author

tsujan commented Dec 11, 2012

In fact, at those occasions, the cleared notification menu isn't closed but remains open with "No notifications" on it and the freeze occurs. So, the cause may be in the function "_clear_all" in cinnamon/applets/notifications@cinnamon.org. Just a guess.

@bwat47
Copy link

bwat47 commented Dec 12, 2012

I haven't had any total freezes of cinnamon, but I have noticed that sometimes after clearing notifications just the notifications applet freezes and doesn't let me open it until I restart cinnamon.

@tsujan
Copy link
Author

tsujan commented Dec 12, 2012

Oh, yes! I've seen that too. Both problems happen when the notifications are cleared with the "Clear notifications" button and both are random.

@mtwebster
Copy link
Member

At the risk of sounding nosy, could you guys list what programs you use that generate most of your notifications? I have a feeling it's a specific program or programs that are causing the problem with the applet - I can fix the applet for sure to handle it, it would just be great to be able to reproduce the behavior while doing so.

@bwat47
Copy link

bwat47 commented Dec 12, 2012

pidgin and networkmanager for me. I don't recall what I was using everytime I saw it freeze (and it happens pretty rarely, I've only seen it happen like 2 or 3 times so far), but most recently I believe it was a networkmanager notification after resuming from suspend, I opened the applet, hit clear, and instead of clearing it the applet froze on me, not letting me open it again (and was still showing that there was an unread notification). If I see it freeze again I'll try to note where the notification came from.

@tsujan
Copy link
Author

tsujan commented Dec 12, 2012

Networkmanager for me. When I resume the system from hibernation, there's a Networkmanager notification because the connection goes off before hibernation. Sometimes, when I use the "Clear notifications" button, the freeze happens. Since yesterday, I just click inside the notification to see if there'll be any freeze in this way.

@bwat47
Copy link

bwat47 commented Dec 13, 2012

Just saw this issue with pidgin as well, only I never hit clear notifications. This time I hit the notify popup right as it was about to disappear and go to the notification applet, it focused the pidgin window like I wanted, but the applet got stuck showing that there is an unread notification and I can't click it.

@tsujan
Copy link
Author

tsujan commented Dec 13, 2012

This is related to the freezes caused by clicking on the "Clear notifications" button:

I changed the function "_clear_all" in cinnamon/applets/notifications@cinnamon.org/applet.js to the following and have seen no freeze for 3 days:

_clear_all: function() {
let count = this.notifications.length;
if (count > 0) {
for (let i = count-1; i >=0; i--) {
let notification = this.notifications[i];
this.notifications.splice(i, 1);
notification.destroy(NotificationDestroyedReason.DISMISSED);
}
}
this.update_list();
}

A few days should pass for knowing that the above change has any effect.

@autarkper
Copy link
Contributor

A notifications fix was merged some time ago. Please reopen if you can reproduce the problem in a recent nightly build or in the upcoming Cinnamon 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants