[1.8] Add invisible auto-scrolling regions to the top and bottom of the application list #1085

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants
Member

mtwebster commented Sep 7, 2012

Addresses #108

Each region has 3 individual sub-regions - slow, medium, fast.

Hovering the mouse in any of these regions scrolls the list up or down
at slow, medium or fast speed.

A small amount of application list real-estate is lost, but I think it's
a fair tradeoff to gain smooth scrolling. The drawback to the old method
was that you had to keep the mouse moving to generate enter/leave events
on the application buttons, otherwise the scrolling would stop.

Couple other notes/caveats:

You lose the effect of the 'selected app' constantly re-highlighting as you make your way through the list, though it immediately picks back up once you back off the auto-scroll area.

The original scroll-to-button code is still used when activating an application context menu that would result in the submenu appearing off-view, so that effect is retained.

It would be great if this pull request could be committed to the master branch before 1.8.

I've just tested this new auto-scrolling menu and it worked great. I suggest you guys create a new branch with these latest (working) features implemented, so that those who want to test them to do so before they are included in the master branch.

Member

glebihan commented Sep 16, 2012

@mdchaves : each pull request is related to a branch, which allows anyone who wants to to test the changes provided by the pull request.
Putting them all together within one branch would actually make testing harder as it wouldn't allow to know for sure which pull request/commit caused a certain regression or bug.
As for when those changes will be merged, we're currently in feature freeze for 1.6, this pull request should get merged after the release of 1.6.

EDIT: Forgot to mention, there's also a decision to make at to whether this pull request should be merged as is or not (I personally wouldn't merge it without a few changes, as auto-scrolling highly annoys me)

mtwebster added some commits Sep 7, 2012

Add invisible auto-scrolling regions to the top and bottom of the app…
…lication list.

Each region has 3 individual sub-regions - slow, medium, fast.

Hovering the mouse in any of these regions scrolls the list up or down
at slow, medium or fast speed.

A small amount of application list real-estate is lost, but I think it's
a fair tradeoff to gain smooth scrolling.  The drawback to the old method
was that you had to keep the mouse moving to generate enter/leave events
on the application buttons, otherwise the scrolling would stop.

@mtwebster: I tested this pull request and it really improves menu navigation. But the sliding movement is not totally smooth yet. It should be more fluid. The rolling speed often changes abruptly. Sometimes it gets too slow. Perhaps the sensitive area should be vertically extended. Maybe if more different “speed regions” were created, the scrolling would improve.
I really think this is a very useful feature. Do you have any idea if and when it would be merged?

Contributor

autarkper commented Oct 29, 2012

For me, this pull request makes fewer items immediately visible in the application list:

master: http://www.autark.se/dump/menu-standard-2012-10-29%2008:00:07.png
butter: http://www.autark.se/dump/menu-with-butter-2012-10-29%2007:56:51.png

Update: the above screenshots were taken on my Ubuntu 12.04 desktop. On my laptop running LMDE I don't see any difference.

Contributor

autarkper commented Oct 29, 2012

I have merged this to my master branch.

Member

mtwebster commented Dec 4, 2012

I'm going to re-do this in the Shell toolkit layer

@mtwebster mtwebster closed this Dec 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment