Skip to content
This repository

Attempt to replace the Gnome-Control-Center keyboard page #1224

Merged
merged 4 commits into from over 1 year ago

5 participants

Michael Webster ScipioAfricanus Albert Pool Scott Garman Clement Lefebvre
Michael Webster
Collaborator

...with settings that actually work.

All functionality should be duplicated here, with the additional advantage
of being able to assign multiple bindings to items that support it.

To do possibly before merge:

  • Add any keys I may have missed or felt didn't need to be in there

Addresses:

#1117
#797
#1174
#722
#713
#544
#974
#549

ScipioAfricanus

@mtwebster
Great work!
I think "Toggle Overview" and "Toggle Expo" are mistakenly switched.
Btw, shouldn't it be "Toggle Scale" instead of "Toggle Overview"?

Thanks for this great feature.

Michael Webster
Collaborator

One issue I see - we have a number of bindings hardcoded in Cinnamon - Alt-tab, Shift-alt-tab, alt-f2 to name a couple. I haven't looked into changing those, but I will. It can only cause confusion if someone assigns one of these 'special' bindings to something else, and it doesn't work.

ScipioAfricanus

I think an option to reset each setting (individually) to its default value would be very useful.

Michael Webster
Collaborator

Moved bindings to the top for easier access, added right-click reset-to-defaults context menu.

And squashed commits

Michael Webster mtwebster referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Michael Webster mtwebster reopened this
Michael Webster mtwebster referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Michael Webster mtwebster referenced this pull request from a commit in mtwebster/Cinnamon
Michael Webster mtwebster Added keyboard module
See #1224 for details
5997167
Albert Pool
Collaborator

@mtwebster Which one do we need, #1264 or this one? Please close one of them.

mtwebster added some commits
Michael Webster mtwebster Attempt to replace the Gnome-Control-Center keyboard page, with setti…
…ngs that

actually work.

All functionality should be duplicated here, with the additional advantage
of being able to assign multiple bindings to items that support it.
9bce902
Michael Webster mtwebster Allow single tap of modifier keys to act as an actual keybinding.
This isn't 100% reliable - you have to get the key press duration just
so for it to take, but with a couple tries you can do it.

Added menu popup keybinding also.
fe40133
Michael Webster mtwebster keyboard: Remove unused argument c73f650
Michael Webster mtwebster Allow shift-f10 and context menu key to activate 'Reset to defaults'
context menu.
8ff8fab
Michael Webster
Collaborator

I guess this one - the other will have to wait, since it breaks every time someone makes a change to cinnamon-settings.

Clement Lefebvre clefebvre merged commit abe460b into from
Scott Garman

Thank you for fixing this - I am so much happier now using Cinnamon. It's a great desktop environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 4 unique commits by 1 author.

Oct 18, 2012
Michael Webster mtwebster Attempt to replace the Gnome-Control-Center keyboard page, with setti…
…ngs that

actually work.

All functionality should be duplicated here, with the additional advantage
of being able to assign multiple bindings to items that support it.
9bce902
Michael Webster mtwebster Allow single tap of modifier keys to act as an actual keybinding.
This isn't 100% reliable - you have to get the key press duration just
so for it to take, but with a couple tries you can do it.

Added menu popup keybinding also.
fe40133
Michael Webster mtwebster keyboard: Remove unused argument c73f650
Michael Webster mtwebster Allow shift-f10 and context menu key to activate 'Reset to defaults'
context menu.
8ff8fab
Something went wrong with that request. Please try again.