Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change modifier type for keybindings page. #1290

Merged
merged 1 commit into from Oct 20, 2012

Conversation

Projects
None yet
3 participants
Member

mtwebster commented Oct 19, 2012

Turns out, MODIFIER_TAP only seems to exist for Ubuntu (I found it in
devhelp), but not in GTK proper, so invalid in pure GTK environments.

This prevents the ability to set a single modifier key as a keybinding,
but all other key combinations are possible as normal.

Fixes #1289

Contributor

dalcde commented Oct 20, 2012

Can we do

try:
    entry_cell.set_property('accel-mode', Gtk.CellRendererAccelMode.MODIFIER_TAP)
except Exception:
    entry_cell.set_property('accel-mode', Gtk.CellRendererAccelMode.OTHER)

so that setting a single modifier key is possible when it is supported?

Use MODIFIER_TAP where allowed, otherwise use OTHER.
Some GTK versions allow a single tap of a modifier to
act as a keybinding, while pure Gnome GTK does not.

clefebvre added a commit that referenced this pull request Oct 20, 2012

Merge pull request #1290 from mtwebster/modifier
Change modifier type for keybindings page.

@clefebvre clefebvre merged commit 64057e2 into linuxmint:master Oct 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment