New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mouse button modifier to Cinnamon window settings (makes it easier to properly use Blender). Added option to add the menu icon to the title bar. #1293

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@rayza
Contributor

rayza commented Oct 21, 2012

Added the mouse button modifier entry, so Blender users can easily change that setting since it's vital to properly use Blender without having to reconfigure it (workflow). "Alt+Right Click" interferes with the Blender shortcut for "Edge Loop Select". On top "Alt+Right Click" opens the same menu as "Alt+Space" so in my opinion it's quite superfluos. Should you prefer to keep it, I'd suggest to map the mouse button modifier to instead by default.

Added option to add the menu icon to the title bar. See the commit comment for more info on that.

Update files/usr/lib/cinnamon-settings/cinnamon-settings.py
Added the mouse button modifier entry, so Blender users can easily change that setting since it's vital to properly use Blender without having to reconfigure it (workflow). "Alt+Right Click" interferes with the Blender shortcut for "Edge Loop Select". On top "Alt+Right Click" opens the same menu as "Alt+Space" so in my opinion it's quite superfluos. Should you prefer to keep it, I'd suggest to map the mouse button modifier to <Super> instead by default.
@autarkper

This comment has been minimized.

Show comment
Hide comment
@autarkper

autarkper Oct 30, 2012

Contributor

I have added this to my master branch.

Contributor

autarkper commented Oct 30, 2012

I have added this to my master branch.

Update files/usr/lib/cinnamon-settings/cinnamon-settings.py
Added the option to show the menu icon in the title bar as well, since many metacity themes support it, (Clearlooks even uses the fancy logo of the application which is running inside the window, which I like) and people should be able to enable it, if there's an option to edit the title bar anyway. Otherwise people might be led to think that there's no option to enable this feature.
@rayza

This comment has been minimized.

Show comment
Hide comment
@rayza

rayza Nov 14, 2012

Contributor

Added the option to place the menu icon in the title bar as well. See commit comment for more info.

Contributor

rayza commented Nov 14, 2012

Added the option to place the menu icon in the title bar as well. See commit comment for more info.

@autarkper

This comment has been minimized.

Show comment
Hide comment
@autarkper

autarkper Nov 14, 2012

Contributor

Great addition! Didn't know that was possible.

Contributor

autarkper commented Nov 14, 2012

Great addition! Didn't know that was possible.

@AlbertJP

This comment has been minimized.

Show comment
Hide comment
@AlbertJP

AlbertJP Nov 14, 2012

Contributor

@rayza You do not have to retain the text "Update file...". It's often more clear to us if you remove this text and replace it by your own title. (No need to re-do the existing commits, however).

Contributor

AlbertJP commented Nov 14, 2012

@rayza You do not have to retain the text "Update file...". It's often more clear to us if you remove this text and replace it by your own title. (No need to re-do the existing commits, however).

@autarkper

This comment has been minimized.

Show comment
Hide comment
@autarkper

autarkper Dec 8, 2012

Contributor

This one needs to be rebased on current master.

Contributor

autarkper commented Dec 8, 2012

This one needs to be rebased on current master.

@rayza

This comment has been minimized.

Show comment
Hide comment
@rayza

rayza Dec 8, 2012

Contributor

Should I close this request and start a new one therefor?

Contributor

rayza commented Dec 8, 2012

Should I close this request and start a new one therefor?

@autarkper

This comment has been minimized.

Show comment
Hide comment
@autarkper

autarkper Dec 8, 2012

Contributor

@rayza : This is quite common when things have changed on the master branch, so a new branch is not necessary. Just force-push to the same branch after rebasing ("git push origin +patch-1") and all will be fine.

Update: whoops, I initially gave the instructions for deleting the branch.

Contributor

autarkper commented Dec 8, 2012

@rayza : This is quite common when things have changed on the master branch, so a new branch is not necessary. Just force-push to the same branch after rebasing ("git push origin +patch-1") and all will be fine.

Update: whoops, I initially gave the instructions for deleting the branch.

@rayza rayza closed this Dec 16, 2012

@rayza

This comment has been minimized.

Show comment
Hide comment
@rayza

rayza Dec 17, 2012

Contributor

I tried. It didn't let me though. Had to completely revamp it.

Contributor

rayza commented Dec 17, 2012

I tried. It didn't let me though. Had to completely revamp it.

@rayza rayza referenced this pull request Dec 17, 2012

Merged

Rebased from #1293 #1514

@e70838

This comment has been minimized.

Show comment
Hide comment
@e70838

e70838 Jan 1, 2013

Hello, I have installed linux mint yesterday (after 4 years of ubuntu). This was very important to disable alt+click because I needs photoshop (via wine). I have modified /usr/lib/cinnamon-settings/cinnamon-settings.py (sudo gedit) using the description at https://github.com/linuxmint/Cinnamon/pull/1293/files. After that, menu "Preferences", "all parameters", "windows", and the new option is available.

It works perfectly. I hope my post will help newbies apply the correction. Thank you very very much for this correction.

e70838 commented Jan 1, 2013

Hello, I have installed linux mint yesterday (after 4 years of ubuntu). This was very important to disable alt+click because I needs photoshop (via wine). I have modified /usr/lib/cinnamon-settings/cinnamon-settings.py (sudo gedit) using the description at https://github.com/linuxmint/Cinnamon/pull/1293/files. After that, menu "Preferences", "all parameters", "windows", and the new option is available.

It works perfectly. I hope my post will help newbies apply the correction. Thank you very very much for this correction.

clefebvre added a commit that referenced this pull request Jan 30, 2013

@goteeguy

This comment has been minimized.

Show comment
Hide comment
@goteeguy

goteeguy Feb 5, 2013

Just tried it... works great. Just what I was looking for. Thanks so much!

goteeguy commented Feb 5, 2013

Just tried it... works great. Just what I was looking for. Thanks so much!

@dev344

This comment has been minimized.

Show comment
Hide comment
@dev344

dev344 Feb 5, 2013

Yep. I just changed my cinnamon-settings.py file and it works!! Thanks to e70838 for giving the confidence.
Menu-> Preferences -> Cinnamon Settings -> Windows will lead you to the option.

@clefebvre, @rayza, etc: Will I have any problem later on when I update mint?

dev344 commented Feb 5, 2013

Yep. I just changed my cinnamon-settings.py file and it works!! Thanks to e70838 for giving the confidence.
Menu-> Preferences -> Cinnamon Settings -> Windows will lead you to the option.

@clefebvre, @rayza, etc: Will I have any problem later on when I update mint?

@Perturbatio

This comment has been minimized.

Show comment
Hide comment
@Perturbatio

Perturbatio Feb 5, 2013

I'd like to say a thank you for this, it's been bugging me for ages, photoshop in wine is not easy to use when you can't change things like this.

I would suggest you backup the original before changing and also make a copy of the changed version somewhere so you can re-apply easily if updates break it.

Perturbatio commented Feb 5, 2013

I'd like to say a thank you for this, it's been bugging me for ages, photoshop in wine is not easy to use when you can't change things like this.

I would suggest you backup the original before changing and also make a copy of the changed version somewhere so you can re-apply easily if updates break it.

@goteeguy

This comment has been minimized.

Show comment
Hide comment
@goteeguy

goteeguy Feb 6, 2013

FYI: I have assigned the Windows key as the mouse modifier. Alter I hold the Windows key & Left Click to drag a window, the default action of the Windows key gets a bit wonky. It does not always show the Menu, and does not always show the window list. Not big issues for me, but thought I'd mention it. Cheers!

goteeguy commented Feb 6, 2013

FYI: I have assigned the Windows key as the mouse modifier. Alter I hold the Windows key & Left Click to drag a window, the default action of the Windows key gets a bit wonky. It does not always show the Menu, and does not always show the window list. Not big issues for me, but thought I'd mention it. Cheers!

@AlbertJP

This comment has been minimized.

Show comment
Hide comment
@AlbertJP

AlbertJP Feb 6, 2013

Contributor

@dev344 Pull request #1514 is already merged so future Cinnamon versions will include that fix. (It's indeed true that manual changes will be undone when you install a newer Cinnamon).

Contributor

AlbertJP commented Feb 6, 2013

@dev344 Pull request #1514 is already merged so future Cinnamon versions will include that fix. (It's indeed true that manual changes will be undone when you install a newer Cinnamon).

@rayza

This comment has been minimized.

Show comment
Hide comment
@rayza

rayza Feb 9, 2013

Contributor

I'm glad you find it useful guys!

Contributor

rayza commented Feb 9, 2013

I'm glad you find it useful guys!

@AlienTux

This comment has been minimized.

Show comment
Hide comment
@AlienTux

AlienTux Feb 24, 2013

Thank you very much rayza!!! I've been looking for this for ages!!!

AlienTux commented Feb 24, 2013

Thank you very much rayza!!! I've been looking for this for ages!!!

tetromino pushed a commit to tetromino/Cinnamon that referenced this pull request Sep 30, 2014

rjanja pushed a commit to rjanja/Cinnamon that referenced this pull request Sep 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment