Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes #1297 #1326

Merged
merged 1 commit into from Nov 5, 2012

Conversation

Projects
None yet
4 participants
Contributor

rilian-la-te commented Nov 3, 2012

Added ABI variable and some if's for gnome 3.4

Member

AlbertJP commented Nov 3, 2012

Thanks. I'll see if this can get into Cinnamon soon.

Member

AlbertJP commented Nov 3, 2012

@clefebvre Mint 13 still works with this.

Contributor

dalcde commented Nov 3, 2012

tabs :)

Contributor

dalcde commented Nov 3, 2012

Looks horrible in github

Member

AlbertJP commented Nov 4, 2012

@rilian-la-te Perhaps you can replace some tabs by spaces (line 219-236 and 238-311). To do that you should make a new commit on the "patch-1" branch, instead of editing the file again in master. You can go to your fork using the "Fork" button at the top, then select the patch-1 branch (to the left of Files/Commits/Branches), and then you can edit the file again.
Please use a better title than "Upgrading ". This is GitHub's default, but it's better to remove this text and replace it by something like "Replace tabs by spaces".

If done well, you will see "rilian-la-te added a commit" appearing here.

Owner

clefebvre commented Nov 5, 2012

Good job! Works well on both 3.4 and 3.6.

@clefebvre clefebvre added a commit that referenced this pull request Nov 5, 2012

@clefebvre clefebvre Merge pull request #1326 from rilian-la-te/patch-1
Fixes #1297
0ac8cf0

@clefebvre clefebvre merged commit 0ac8cf0 into linuxmint:master Nov 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment