Fix for pixelated alt-tab entries #1333

Merged
merged 6 commits into from Nov 13, 2012

Conversation

Projects
None yet
3 participants
@mtwebster
Member

mtwebster commented Nov 7, 2012

Window tracker: Strip extension from window class when using it for app lookup.

The WM_CLASS is set to the app full name (i.e. cinnamon-settings.py) and then
it uses that to try to find the app during certain operations. It appends .desktop
to that string, and searches for the desktop entry, and, of course, does not find it.

app-system: check settings hash table for app as well as the normal table, when doing
a search.

All of this goes towards addressing the problem with cinnamon and mint applications
showing up as pixelated in the alt-tab view.

Need to add a desktop entry for cinnamon menu editor and the panel launchers .py file (I think we can set it to no display so it's not visible in the menu applet, but still in the app system)

With this patch and manually renaming desktop files on my system, it solved the pixelation problem.

Looking at the rest of my desktop files in /usr/share/applications, it looks like the rule is all lower-case, most likely for this reason, as every app that was working fine with regards to the icon pixelation retrieved its desktop entry via the WM_CLASS name path.

Window tracker: Strip extension from window class when using it for a…
…pp lookup.

The WM_CLASS is set to the app full name (i.e. cinnamon-settings.py) and then
it uses that to try to find the app during certain operations.  It appends .desktop
to that string, and searches for the desktop entry, and, of course, does not find it.

app-system: check settings hash table for app as well as the normal table, when doing
a search.

All of this goes towards addressing the problem with cinnamon and mint applications
showing up as pixelated in the alt-tab view.
@gauravjuvekar

This comment has been minimized.

Show comment Hide comment
@mtwebster

This comment has been minimized.

Show comment Hide comment
@mtwebster

mtwebster Nov 7, 2012

Member

Yes

Member

mtwebster commented Nov 7, 2012

Yes

mtwebster added some commits Nov 7, 2012

Collect settings apps even if they're NoDisplay - we already filter
this stuff out in our menus and such, we should track them from a
window/system point of view though.
Add a secondary hash table search that checks without regard to
case if the initial (fast) lookup doesn't yield any results.

The benefit of this is we won't have to rename all our .desktop
files for mint programs.

The downside is that unexpected things might happen if for some
reason you have duplicate .desktop files that differ only in
character cases (not likely).
@mtwebster

This comment has been minimized.

Show comment Hide comment
@mtwebster

mtwebster Nov 7, 2012

Member

Last commit eliminates the need to rename all our desktop files. The app system will try a normal, fast hash table lookup for the desktop file. If it fails to find it, it will initiate a somewhat slower, but case insensitive, find routine, that will hopefully give us the desktop file we're really looking for.

Member

mtwebster commented Nov 7, 2012

Last commit eliminates the need to rename all our desktop files. The app system will try a normal, fast hash table lookup for the desktop file. If it fails to find it, it will initiate a somewhat slower, but case insensitive, find routine, that will hopefully give us the desktop file we're really looking for.

mtwebster added some commits Nov 8, 2012

Change the name of the panel launcher editor to be more in line with
other Cinnamon utilities.  Give it a .desktop file so it gets the nice
rendering.

clefebvre added a commit that referenced this pull request Nov 13, 2012

Merge pull request #1333 from mtwebster/pixelated
Fix for pixelated alt-tab entries

@clefebvre clefebvre merged commit 61f3bc1 into linuxmint:master Nov 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment