Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts fix for 3.6/Mint 14 #1405

Merged
merged 2 commits into from Dec 15, 2012

Conversation

mtwebster
Copy link
Member

Addresses #549 zombie issue and #1427

From Mint 13 (Gnome 3.4) to Mint 14 (Gnome 3.6) the location of custom keyboard shortcuts storage was moved from gconf to gsettings. Terminal launch shortcut was also given its own settings key (rather than existing only as a pre-made custom shortcut)

This patch

a) Adds a permanent Terminal shortcut entry under "Launchers"

b) Detects which storage method is in use for custom shortcuts and stores them in gsettings if applicable. Note that for now, to simplify the update, we are also mirroring the shortcuts in gconf as well.

c) Has a run-once clause for upgrades from Mint 13 to 14 that will transition all existing custom shortcuts to the new system. The user has only to run cinnamon-settings for the first time after an upgrade and this will be performed.

@autarkper
Copy link
Contributor

(Ubuntu 12.04)

I merged this to my master branch and opened cinnamon-settings, but as soon as I tried to open the Keyboard tab, cinnamon-settings crashed:

(cinnamon-settings.py:9349): GLib-GIO-ERROR **: Settings schema 'org.gnome.settings-daemon.plugins.media-keys' does not contain a key named 'terminal'

@mtwebster
Copy link
Member Author

Oops I need to make that conditional on mint 14 as well, thanks for testing.

@mtwebster
Copy link
Member Author

updated and rebased

@autarkper
Copy link
Contributor

This time no problem on Ubuntu 12.04. But, it still fails with the same message on LMDE (testing).

@Redsandro
Copy link
Contributor

For me, custom shortcuts don't work at all.
I can edit them at:
Keyboard > Keyboard shortcuts > Custom
but they just don't work. (Mint 14 x64 Cinnamon)

So if they work for you, it looks like they only work after upgrading fro 13, not after a clean install. Correct?

@mtwebster
Copy link
Member Author

Until this gets merged, and released with a new cinnamon version, Mint 14 users can look here:

http://forums.linuxmint.com/viewtopic.php?f=208&t=117585&start=20#p655476

For a workaround to bring back the old Gnome-Control-Center keyboard page, which is working.

@Redsandro
Copy link
Contributor

Thank you for mentioning it here. I hadn't seen that thread.

glebihan added a commit that referenced this pull request Dec 15, 2012
Keyboard shortcuts fix for 3.6/Mint 14
@glebihan glebihan merged commit c05d7a0 into linuxmint:master Dec 15, 2012
@Lusito
Copy link
Contributor

Lusito commented Dec 21, 2012

I just noticed that if you change the command line of a custom shortcut, it won't update until you update the key-binding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants