PopupMenu: update position and fix size before tweening out #8046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We update the position on allocate() but skip this if we're tweening. Updating it here ensures it's correct before we start animating, and setting a fixed size should keep it from automatically resizing.
Curly060
pushed a commit
to Curly060/Cinnamon
that referenced
this pull request
Jan 2, 2019
…t#8046) * PopupMenu: update position and fix size before tweening out We update the position on allocate() but skip this if we're tweening. Updating it here ensures it's correct before we start animating, and setting a fixed size should keep it from automatically resizing. * put the code in the proper place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We update the position on allocate() but skip this if we're tweening.
Updating it here ensures it's correct before we start animating,
and setting a fixed size should keep it from automatically resizing.
master:
this branch:
