Skip to content

PopupMenu: update position and fix size before tweening out #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2018
Merged

PopupMenu: update position and fix size before tweening out #8046

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68ea6a9
PopupMenu: update position and fix size before tweening out
itzexor Nov 21, 2018
d4583f3
put the code in the proper place
itzexor Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
put the code in the proper place
  • Loading branch information
@itzexor
itzexor committed Nov 21, 2018
commit d4583f3cd6203562b1c93a073bdebb501999ce04
5 changes: 2 additions & 3 deletions js/ui/popupMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2325,10 +2325,9 @@ var PopupMenu = class PopupMenu extends PopupMenuBase {
if (this._activeMenuItem)
this._activeMenuItem.setActive(false);

this.actor.set_position(...this._calculatePosition());
this.actor.set_size(...this.actor.get_size());

if (animate && global.settings.get_boolean("desktop-effects-on-menus")) {
this.actor.set_position(...this._calculatePosition());
this.actor.set_size(...this.actor.get_size());
this.animating = true;
let tweenParams = {
transition: "easeInQuad",
Expand Down