Ui rework / hotplugging fixups #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-main status icon and bluetooth switch now inside a header bar -settings page converted into a popover on a menu button "under the hood": -statuc ui components designed with glade/gtkbuilder -single stack page for status: there is just a status label and a status icon to be updated and a "status-page" to switch to when things are disabled or unplugged instead of one stack page per device state.
by unconditionally starting the event monitor and handling finding and losing devices.
we can get there quick with a single hotpluggable bluetooth device
instead of using the status stack page which prevents use of the bluetooth widget, we now show an error icon next to the switch and disable it while not changing any other state. If bluetooth is blocked then we end up in a bluetooth disabled + switch disabled state, otherwise we end up in a normal view with the switch disabled.
clefebvre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Hardware RF switch untested. I expect it works as usual though, it should show a page identical to bluetooth disabled in the screenshot below except with the additional "by hardware switch" text.
UI cleanup:
gnome-bluetooth BluetoothSettingsWidget override fix:
Widget override code now loops through widgets to find them instead of using a hardcoded "path". It's still fragile. Adding version-specific code is probably the best approach if it breaks again.
Better support for hotpluggable devices:
Better rfkill error state presentation:
Previously, when the user did not have permission to /dev/rfkill, the main status page was used to show an error state with a bluetooth disabled icon and the switch set to off and insensitive. This would likely be reached most often by a user attempting to disable bluetooth. This layout may be misleading because it could suggest that bluetooth is disabled when it's actually still enabled and discoverable, and that the application no longer worked because of rfkill permission issues.
The new layout places an rfkill-error-specific image which shows a dialog-error icon next to the toggle switch when an enable/disable operation fails. The error is explained by the image's tooltip which may have low discoverability. A new message was added that explains having a udev rule or being in the rfkill group can fix permissions issues.
This rfkill-specific error state no longer modifies the powered or present states for bluetooth adapter status, which allows the application to work as expected regardless of rfkill permissions.