Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for online-accounts #181

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@besser82
Copy link
Contributor

besser82 commented Sep 8, 2017

This PR adds optional integration for gnome-online-accounts into cinnamon-settings.

This comes in handy, if you want to use gDrive from Nemo or automatically renew your Kerberos credentials for some services.

Ported from gnome-controll-center 3.24.X branch.


These PRs are needed for this feature:

@besser82 besser82 force-pushed the besser82:enhancement/coa branch 4 times, most recently from 0d178be to 38e3f42 Sep 8, 2017

@besser82

This comment has been minimized.

Copy link
Contributor Author

besser82 commented Sep 8, 2017

I've checked for functionality on Fedora 26+ and it works without any issues.

@besser82

This comment has been minimized.

Copy link
Contributor Author

besser82 commented Sep 8, 2017

@leigh123linux Just finished testing with RHEL7 (GTK-3.22 / GOA 3.22) and everythings work smoothly there, too.

@besser82 besser82 force-pushed the besser82:enhancement/coa branch from 38e3f42 to fa90577 Sep 13, 2017

@besser82

This comment has been minimized.

Copy link
Contributor Author

besser82 commented Sep 15, 2017

@clefebvre Any thoughts?

@clefebvre

This comment has been minimized.

Copy link
Member

clefebvre commented Sep 26, 2017

Hi @besser82,

Here's my feedback. As it is I don't think it's a good idea to add GOA support in Cinnamon. It looks completely out of place and pretty much ALPHA to me.

I'll start with the technical issues:

  • The requirement in configure.ac is set to 3.21, it should be changed to 3.18.0.

  • In the Cinnamon PR, an icon for cs-online-accounts is needed. I noticed you added it to Mint-Y, it's needed in Cinnamon itself as well.

  • The C panel doesn't expand properly in the cinnamon-settings window. Should be easy to fix in the UI file, or by embedding the C panel in a Python module in cinnamon-settings.

  • Once an account is enabled, say Google... I'm only able to remove it. I'm not sure if it's a bug or a limitation with 3.18, but I can't pin-point which Google services to give access to.

  • Removing an account only seems to remove it locally. Access given to the app GNOME isn't removed online. I can reproduce this with Google for instance.

  • Facebook doesn't seem to work. Once added it doesn't go into the top list.

Now, onto my real worries:

  • There is no indication as to whether or not passwords are saved. As far as I can see, with Google anyhow, a token is saved and thus you don't need to enter them twice. This is important info for users, novice included. That's easily added in CCC.

  • There is no indication as to what accounts are for and what apps use them. In a GNOME environment where all apps take advantage of this, it might make sense, in a Cinnamon environment where these apps are 3rd party and often not present on the system it creates confusion.

  • The list of online services is hardcoded and so are the app ID and secrets. These apps are named GNOME and they refer to an environment that isn't ours. That makes sense within a GNOME DE, but it doesn't here.

  • From a design point of view, I don't understand why this is implemented like this. First, if this is to be used outside of GNOME it should be done cross-DE, not replicated into Cinnamon. So I would prefer an Xapp client rather than a CCC panel. Second, why create a place for online accounts which aren't used by any apps? Or if these are used by one app, why not have that app support the online account directly?

The real question here is... why are we doing this? In what purpose? Is it simply to let people connect to Google Drive with Nemo? Does it encompass other use cases? Can we list them and from there think of the best way to implement solutions for these?

@clefebvre

This comment has been minimized.

Copy link
Member

clefebvre commented Sep 27, 2017

I'm a bit annoyed because I can see the value of this for Nemo users wanting to connect to Google Drive... or GNOME apps users using Cinnamon (although I'm not really clear on what apps support what services... and I wouldn't mind having that written somewhere for the user to see)....

.. and yet the design is very confusing, because it gives the feeling of something really integrated into the OS (kinda like what you do with your phone) and yet nothing much will work out of the box.

I'm not sure this is good for us long term and we might remove it at some stage, but we've always been pragmatic, and we've got to accept the fact that some of the cases (like mounting google drive) are solved by this and are really tedious without it.

I'm tempted to embed the CCC panel into a python module and add support in Cinnamon, but with a disclaimer.

@clefebvre clefebvre merged commit 37cd387 into linuxmint:master Oct 3, 2017

@besser82 besser82 deleted the besser82:enhancement/coa branch Oct 3, 2017

felixonmars-bot pushed a commit to felixonmars/archlinux-community that referenced this pull request Apr 19, 2018

eschwartz
Move gnome-online-accounts to optdepends.
c-c-c gracefully handles the case of it being absent at runtime. And this isn't
really tied in very well in the first place:
linuxmint/cinnamon-control-center#181

It doesn't need to be on most users' systems.



git-svn-id: file:///srv/repos/svn-community/svn@317043 9fca08f4-af9d-4005-b8df-a31f2cc04f65

khurshid-alam added a commit to khurshid-alam/Unity-Control-Center that referenced this pull request Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.