Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make infobar use the info style color for "All dependancies are satisfied." reference Iss… #5

Merged
merged 1 commit into from
Aug 28, 2017

Conversation

SketchNI
Copy link
Contributor

Make infobar blue for "All dependancies are satisfied." reference Issue #4

@JosephMcc
Copy link

No issues with this but just some general info. This doesn't actually make the infobar blue. It just adds the info style class to so it will pick up that style as set by your current gtk theme.

@SketchNI
Copy link
Contributor Author

Well, even that's fair enough. Myself and the user who created Issue #4 were in the same mind that it shouldn't be coloured as a warning message as it is information.

@JosephMcc
Copy link

You're correct, it shouldn't be using the warning color in that case. Just wasn't sure if you knew what was happening there since your commit message is a little misleading.

@SketchNI
Copy link
Contributor Author

I'll be honest with you here and say no, I didn't know it was styled depending on the gtk theme but as a happy coincidence, I didn't write any new code to make it blue. Wonder if I can edit a commit message..

@SketchNI SketchNI changed the title Make infobar blue for "All dependancies are satisfied." reference Iss… Make infobar use the info style color for "All dependancies are satisfied." reference Iss… Jul 16, 2017
@clefebvre clefebvre merged commit b4a9d79 into linuxmint:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants