Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for manual /target #2

Merged
merged 4 commits into from Dec 12, 2012

Conversation

TheBlueMatt
Copy link
Contributor

This adds support for the user to mount /target by themselves and then run the installer.
This is useful in cases where the user wishes to install eg across multiple volumes, on RAID, using dm-crypt, dmraid, etc.
It very clearly warns the user away from this choice, as they are then forced to create their own /etc/fstab (the only other extra steps for users who opt to take this route).

The first commit fixes a few minor typos, and points out a pretty serious security flaw in install.py:
install.py writes the user's password to disk in plain text and them deletes it using rm, leaving it on disk.

Matt Corallo added 2 commits April 20, 2012 20:53
Dont write user's new password to disk in plaintext.
(so that the custom partition stuff will be closer to the end)
@TheBlueMatt
Copy link
Contributor Author

Fixed the security TODO and tweaked the wordings on the dialogs a bit.
Should be pretty much good to pull now.

clefebvre added a commit that referenced this pull request Dec 12, 2012
Add support for manual /target
@clefebvre clefebvre merged commit f1131d3 into linuxmint:master Dec 12, 2012
sulincix added a commit to PuffOS/17g-installer that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants