Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding layout for non-latin choises to target #88
Conversation
xenopeek
added
the
In Progress
label
Aug 3, 2018
Chocobo-ts
referenced this pull request
Aug 3, 2018
Closed
live-installer: non-latin keyboard should be added, not set. #10
kernc
referenced this pull request
Aug 3, 2018
Merged
Additional layout in live-session for non-latin choises #89
kernc
reviewed
Aug 3, 2018
| 'gh', 'gr', 'guj', 'guru', 'il', 'in', 'ir', 'iku', | ||
| 'kan', 'kh', 'kz', 'la', 'lao', 'lk', 'mk', 'mm', 'mn', | ||
| 'mv', 'mal', 'ori', 'pk', 'ru', 'scc', 'sy', 'syr', | ||
| 'tel', 'th', 'tj', 'tam', 'ua', 'uz'): |
This comment has been minimized.
This comment has been minimized.
kernc
Aug 3, 2018
Contributor
Define the list somewhere separately:
NONLATIN_KEYBOARD_LAYOUTS = ...Will also make it defined in a single place and can be reused (e.g. as in #89).
| 'kan', 'kh', 'kz', 'la', 'lao', 'lk', 'mk', 'mm', 'mn', | ||
| 'mv', 'mal', 'ori', 'pk', 'ru', 'scc', 'sy', 'syr', | ||
| 'tel', 'th', 'tj', 'tam', 'ua', 'uz'): | ||
| setup.keyboard_layout = 'us,%s' % self.setup.keyboard_layout |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| newconsolefh.write("XKBLAYOUT=\"%s\"\n" % setup.keyboard_layout) | ||
| elif(line.startswith("XKBVARIANT=") and setup.keyboard_variant is not None): | ||
| newconsolefh.write("XKBVARIANT=\"%s\"\n" % setup.keyboard_variant) | ||
| elif(line.startswith("XKBOPTIONS=")): | ||
| newconsolefh.write("XKBOPTIONS=grp:alt_shift_toggle") |
This comment has been minimized.
This comment has been minimized.
kernc
Aug 3, 2018
Contributor
Isn't this a little to much to assume and pre-set for the user? Is Alt+Shift standard shortcut to switch layouts?
This comment has been minimized.
This comment has been minimized.
Chocobo-ts
Aug 4, 2018
•
Author
Contributor
Yes, Alt+Shift is most frequently shortcut for it)
And everything in this fix - based on ubiquity behavoir
clefebvre
merged commit 82e4641
into
linuxmint:master
Aug 5, 2018
xenopeek
removed
the
In Progress
label
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Chocobo-ts commentedAug 3, 2018
Additional US layout and toggle hotkey for choosed non-latin layouts in target system