Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spotify icons #16

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
2 participants
@zystvan
Copy link
Contributor

zystvan commented Feb 1, 2017

The current icon theme has Spotify's old logo. I'm terrible with photo editors and such, but I tried to make these look consistent with the rest of the icons 馃槃

@JosephMcc

This comment has been minimized.

Copy link
Contributor

JosephMcc commented Feb 1, 2017

There are a couple of issues with these. If you look especially at the larger sizes you'll notice that the icon is a different size within the canvas. It doesn't have the same amount of empty space around it. This will make the icon seem to be a different size then others in the theme. Also look at the original and notice that it has a bit of a dark border or outline around it. Yours is missing that and the icon won't stand out well enough against the background.

@zystvan

This comment has been minimized.

Copy link
Contributor Author

zystvan commented Feb 1, 2017

@JosephMcc Thanks for the input, I'll try to fix those issues :)

@zystvan

This comment has been minimized.

Copy link
Contributor Author

zystvan commented Feb 1, 2017

@JosephMcc I'm using the Moka template thing properly now (I think), but render-bitmaps.py keeps generating my icons larger than they should be, for example 273 instead of 256 and 17 instead of 16 px wide/tall. Any ideas what I'm doing wrong? My Spotify SVG icon file is here if you want to download it and try yourself:

https://www.dropbox.com/s/oq63o91tmk5o6tb/web-spotify.svg?dl=0

Other than the issue with size, do these look good now?

Spotify icon

Thanks!

@zystvan

This comment has been minimized.

Copy link
Contributor Author

zystvan commented Feb 2, 2017

@JosephMcc I resized them to the correct size and they have the border and shadow now. Anything else I need to fix?

@JosephMcc

This comment has been minimized.

Copy link
Contributor

JosephMcc commented Feb 2, 2017

Could you squash this down to a single commit? Then I'll merge it. Thanks for putting in the effort.

@zystvan zystvan force-pushed the zystvan:master branch from 5feca00 to 3a7f80c Feb 2, 2017

@zystvan

This comment has been minimized.

Copy link
Contributor Author

zystvan commented Feb 2, 2017

@JosephMcc Sure, done.

Thanks!

@JosephMcc JosephMcc merged commit 3a3a84f into linuxmint:master Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.