New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package selection gets reset if update fails #120

Closed
kneekoo opened this Issue Sep 10, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@kneekoo
Copy link

kneekoo commented Sep 10, 2015

mintUpdate 4.9.2

Having an unstable connection, my update failed while it was trying to get packages. Once I clicked the Close button on the error message window, mintUpdate displayed the updates list with all of them selected, although I only had selected a few of them.

To reproduce this issue I clicked Clear to deselect all the updates, then I selected one package and I clicked Install updates. After entering my password I disabled my network and let mintUpdate fail like you see below.

W: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/b/bash-completion/bash-completion_2.1-4ubuntu0.1_all.deb
Could not resolve 'archive.ubuntu.com'

It happened just as before: I closed the error message window and all the updates were selected.

@JosephMcc

This comment has been minimized.

Copy link
Contributor

JosephMcc commented Aug 29, 2016

Could you retest this in Mint18 with the newer mintupdate?

@kneekoo

This comment has been minimized.

Copy link
Author

kneekoo commented Aug 29, 2016

The issue is still present.

@JosephMcc JosephMcc added BUG and removed CLOSE IF NO RESPONSE labels Aug 29, 2016

@brennanhm

This comment has been minimized.

Copy link
Contributor

brennanhm commented Oct 17, 2016

Hi there,

When the user clicks the Install button, Mint Update executes Synaptic to install the selected packages. We can check the last entry in the apt log to see if Synaptic actually installed any of them. If so, then we need to call the refresh thread to update the list of available packages.

On the other hand, if the connection times out or the user cancels before any packages are installed, we can skip the refresh thread and change the app status to "could not install the security updates". In this case, the packages the user had unchecked would remain unchecked.

I'll submit a PR for this...

More info: If any of the selected packages were successfully installed, then the last entry in the apt log will contain the temporary file name (f.name) and the string "End-Date".

brennanhm pushed a commit to brennanhm/mintupdate that referenced this issue Oct 17, 2016

brennanhm
Prevent reset of package selection if update fails - issue linuxmint#120


- Check the apt history log to see if the update was successful
- Skip refresh of packages if nothing was installed

clefebvre added a commit that referenced this issue Nov 5, 2016

Merge pull request #182 from brennanhm/issue_120
Prevent reset of package selection if update fails - issue #120

@clefebvre clefebvre closed this Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment