Skip to content

Commit

Permalink
Remove landing view
Browse files Browse the repository at this point in the history
A dedicated xapp called thingy is taking care of that now.
https://github.com/linuxmint/thingy

Other than the fact that thingy will do more and be faster to develop, this also fixes
a huge performance issue.

The xreader landing page actually opened each document (i.e. loaded all of its content)
just to generate a thumbnail. With a few mangas in the recent list of opened documents
this meant xreader took up to 4 or 5 minutes to actually load when no URI was specified.

Thingy just relies on Gio to load thumbs and opens instantly.
  • Loading branch information
clefebvre committed Nov 12, 2021
1 parent 8d15e7a commit 8f8e06e
Show file tree
Hide file tree
Showing 9 changed files with 5 additions and 816 deletions.
6 changes: 0 additions & 6 deletions data/org.x.reader.gschema.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,4 @@
</key>
</schema>

<schema id="org.x.reader.state" path="/org/x/reader/state/" gettext-domain="xreader">
<key name="last-landing-page" type="s">
<default>'recent_files'</default>
</key>
</schema>

</schemalist>
7 changes: 3 additions & 4 deletions shell/ev-application.c
Original file line number Diff line number Diff line change
Expand Up @@ -690,19 +690,18 @@ ev_application_open_uri_at_dest (EvApplication *application,
}

/**
* ev_application_open_landing_view:
* ev_application_open_window:
* @application: The instance of the application.
* @timestamp: Current time value.
*
* Creates a new window with recent files
* Creates a new window
*/
void
ev_application_open_landing_view (EvApplication *application,
ev_application_open_window (EvApplication *application,
GdkScreen *screen,
guint32 timestamp)
{
GtkWidget *new_window = ev_window_new ();
ev_window_open_landing_view (EV_WINDOW (new_window));

if (screen) {
ev_stock_icons_set_screen (screen);
Expand Down
2 changes: 1 addition & 1 deletion shell/ev-application.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ void ev_application_open_uri_at_dest (EvApplication *applic
EvWindowRunMode mode,
const gchar *search_string,
guint32 timestamp);
void ev_application_open_landing_view (EvApplication *application,
void ev_application_open_window (EvApplication *application,
GdkScreen *screen,
guint32 timestamp);
void ev_application_open_uri_list (EvApplication *application,
Expand Down
Loading

0 comments on commit 8f8e06e

Please sign in to comment.