You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have read the contributing guideline and understand that I have made the correct modifications
Description:
Added a cookie expiration of one week to allow long-running browser sessions to request new cookie.
Added a try-except block around the second cookie decode attempt to allow invalid cookies to be removed.
Benefits of this PR and context:
Applying these changes locally allowed my long-running browser sessions to automatically request login credentials again. Invalid cookies were handled properly due to the new try-except logic and new cookies have an expiration of one week so the browser will automatically request credentials after the cookie has expired.
I deployed these changes in my personal Docker stack with other applications using ldap-auth. The changes worked immediately as I had several long-running tabs with "500 Internal Server Error" errors now properly show the ldap-auth login page.
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-project-automation
bot
moved this from PRs
to PRs Approved
in Issue & PR Tracker
Description:
Added a cookie expiration of one week to allow long-running browser sessions to request new cookie.
Added a try-except block around the second cookie decode attempt to allow invalid cookies to be removed.
Benefits of this PR and context:
Applying these changes locally allowed my long-running browser sessions to automatically request login credentials again. Invalid cookies were handled properly due to the new try-except logic and new cookies have an expiration of one week so the browser will automatically request credentials after the cookie has expired.
Closes #60
How Has This Been Tested?
I deployed these changes in my personal Docker stack with other applications using ldap-auth. The changes worked immediately as I had several long-running tabs with "500 Internal Server Error" errors now properly show the ldap-auth login page.
Source / References:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie