Skip to content

Conversation

@dongshuzhao
Copy link

@dongshuzhao dongshuzhao commented Nov 12, 2021

resolve #98

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

Added DNSPod support for swag-docker.
DNSPod is one of the most popular DNS service providers in China.

Initial issue: #98

How Has This Been Tested?

Test on my own home server with my own domain and DNSPod account.
DNS-01 challenge is smooth and certificates are properly issued.

Environment:
Docker 20.10.5

Testing log:
image

Source / References:

certpod-dns-dnspod: https://github.com/SkyLothar/certbot-dns-dnspod

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

@dongshuzhao dongshuzhao changed the title Add DnsPod support. Add DNSPod support. Nov 12, 2021
@dongshuzhao dongshuzhao changed the title Add DNSPod support. Add DNSPod support Nov 12, 2021
@aptalca aptalca self-assigned this Nov 12, 2021
@aptalca
Copy link
Member

aptalca commented Nov 12, 2021

Upstream docs suggest the use of dns_dnspod_api_id but you PRed dns_dnspod_email. Was that an error?

@dongshuzhao
Copy link
Author

Upstream docs suggest the use of dns_dnspod_api_id but you PRed dns_dnspod_email. Was that an error?

Sorry I was quoting a wrong fork of certbot-dns-dnspod plugin. The one in pip is maintained by SkyLothar (https://github.com/SkyLothar/certbot-dns-dnspod), which can be checked at https://pypi.org/project/certbot-dns-dnspod/ .
Fixed the comments in the conf file. The code was working correctly though.

Thanks for your reminder.

@LinuxServer-CI
Copy link
Contributor

@LinuxServer-CI
Copy link
Contributor

@aptalca aptalca merged commit f9090d4 into linuxserver:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hope to add support for dnspod

3 participants