Skip to content

Conversation

@svengeance
Copy link

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds support for the GoDaddy DNS plugin provided by https://github.com/miigotu/certbot-dns-godaddy

Benefits of this PR and context:

Enables users who are stuck with utilizing GoDaddy as their DNS provider to seamlessly use SWAG.

How Has This Been Tested?

Essentially following the previous PR here

  • Checkout SWAG repository
  • Follow steps outlined in above PR to add GoDaddy plugin
  • Build image locally via Dockerfile
  • Create and run compose file (first with STAGING=true, then with false)
    • godaddy.ini created under ./config/dns-conf/godaddy.ini
  • Verify site is up and running as expected, watched DNS records get created via GoDaddy plugin and subsequently cleaned up.
services:
  swag:
    cap_add:
      - NET_ADMIN
    container_name: swag
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=America/Chicago
      - URL=my-site.com
      - VALIDATION=dns
      - SUBDOMAINS=wildcard
      - DNSPLUGIN=godaddy
      - PROPAGATION=300
      - ONLY_SUBDOMAINS=false
      - STAGING=false
    image: localhost/swag:latest
    ports:
      - 80:80
      - 443:443
    restart: unless-stopped
    volumes:
      - ./config/nginx/site-confs/:/config/nginx/site-confs:z
      - ./config/dns-conf/:/config/dns-conf:z
Wildcard cert for my-site.com will be requested
No e-mail address entered or address invalid
dns validation via godaddy plugin is selected
Generating new certificate
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Account registered.
Requesting a certificate for *.my-site.com and my-site.com
Waiting 300 seconds for DNS changes to propagate

Successfully received certificate.
Certificate is saved at: /etc/letsencrypt/live/my-site.com/fullchain.pem
Key is saved at:         /etc/letsencrypt/live/my-sitecom/privkey.pem
This certificate expires on 2022-12-12.
These files will be updated when the certificate renews.
NEXT STEPS:
- The certificate will need to be renewed before it expires. Certbot can automatically renew the certificate in the background, but you may need to take steps to enable that functionality. See https://certbot.org/renewal-setup for instructions.

Source / References:

https://github.com/linuxserver/docker-swag/pull/256/files
@thespad Was also kind enough to give me the initial direction over Discord.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending merge of #169

@aptalca
Copy link
Member

aptalca commented Sep 22, 2022

Please rebase (also update the changelog entry) and we'll merge

Thanks

@nemchik nemchik mentioned this pull request Oct 4, 2022
@nemchik
Copy link
Member

nemchik commented Oct 4, 2022

Closing.
Added in #275

@nemchik nemchik closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants