You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My personal testing has been successful. I have tested DNS validation with DuckDNS in staging mode. I did some preliminary testing with the ZeroSSL jq changes (manually running the commands, they work, but i have not tried using ZeroSSL in SWAG).
I believe everything built-in with SWAG should work without issue, but this opens up the ability for users to do whatever they want with cli.ini such as manual-auth-hook. I do not believe we should support (or even document) the ability to do things with cli.ini. This capability should also resolve requests to change the key-type (current default is ecdsa) or set rsa-key-size to whatever value.
Adjust REV_ACMESERVER handling
Rewrite domain handling
Use jq instead of python for ZeroSSL vars
Use existing EAB values for revoke
Attempt to revoke by name if cert path does not exist
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEEDS SIGNIFICANT TESTING!
My personal testing has been successful. I have tested DNS validation with DuckDNS in staging mode. I did some preliminary testing with the ZeroSSL
jqchanges (manually running the commands, they work, but i have not tried using ZeroSSL in SWAG).I believe everything built-in with SWAG should work without issue, but this opens up the ability for users to do whatever they want with
cli.inisuch asmanual-auth-hook. I do not believe we should support (or even document) the ability to do things withcli.ini. This capability should also resolve requests to change thekey-type(current default isecdsa) or setrsa-key-sizeto whatever value.Ref: https://eff-certbot.readthedocs.io/en/stable/using.html#configuration-file
Adjust REV_ACMESERVER handling
Rewrite domain handling
Use jq instead of python for ZeroSSL vars
Use existing EAB values for revoke
Attempt to revoke by name if cert path does not exist