You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have read the contributing guideline and understand that I have made the correct modifications
Description:
This change adds the certbot-dns-dreamhost python module to the container, allowing for certbot dns verification to be done using the dreamhost DNS api.
Benefits of this PR and context:
This change provides an additional dns verification mechanism, meaning that users of dreamhost are able to use dns verification for certbot on the SWAG instances.
How Has This Been Tested?
I have tested this change by building the project locally and running one of my swag instances with the updates docker image and dreamhost dns configuration. The swag instance was succesfully able to generate new certbot certificates (covering 4 sub domains) using dreamhost dns.
This looks good to me, but I'd like #339 to merge first, which would require this to be rebased. I've tagged this as awaiting approval so it does not go stale.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Description:
This change adds the certbot-dns-dreamhost python module to the container, allowing for certbot dns verification to be done using the dreamhost DNS api.
Benefits of this PR and context:
This change provides an additional dns verification mechanism, meaning that users of dreamhost are able to use dns verification for certbot on the SWAG instances.
How Has This Been Tested?
I have tested this change by building the project locally and running one of my swag instances with the updates docker image and dreamhost dns configuration. The swag instance was succesfully able to generate new certbot certificates (covering 4 sub domains) using dreamhost dns.
Source / References: