Skip to content

Conversation

@ejach
Copy link
Contributor

@ejach ejach commented Jun 25, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Added certbot-dns-bunny to SWAG allowing certificates to be generated from Bunny.

Benefits of this PR and context:

If this change is merged, this will close #389 and allow the above to be able to be utilized in a SWAG instance.

How Has This Been Tested?

I tested this by generating new certificates for an existing Bunny site after building the image locally and running it on an arm64 environment. This was successfully able to generate new certificates in this instance using the new certbot plugin.

Source / References:

#389

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@ejach ejach mentioned this pull request Jun 25, 2023
1 task
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-6491eef3-dev-fac669ea4302bc1b6bca7308ef32aa4e21a9c255-pr-390/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-6491eef3-dev-fac669ea4302bc1b6bca7308ef32aa4e21a9c255-pr-390/shellcheck-result.xml

Tag Passed
amd64-2.6.0-pkg-6491eef3-dev-fac669ea4302bc1b6bca7308ef32aa4e21a9c255-pr-390
arm64v8-2.6.0-pkg-6491eef3-dev-fac669ea4302bc1b6bca7308ef32aa4e21a9c255-pr-390

@ejach ejach changed the title Added certbot-dns-bunny Added certbot-dns-bunny to allow Bunny dns verification Jun 26, 2023
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-38c05ab2-dev-eaf8b3648bd6852b68d9c56798c7e7c78be29a54-pr-390/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-38c05ab2-dev-eaf8b3648bd6852b68d9c56798c7e7c78be29a54-pr-390/shellcheck-result.xml

Tag Passed
amd64-2.6.0-pkg-38c05ab2-dev-eaf8b3648bd6852b68d9c56798c7e7c78be29a54-pr-390
arm64v8-2.6.0-pkg-38c05ab2-dev-eaf8b3648bd6852b68d9c56798c7e7c78be29a54-pr-390

@nemchik
Copy link
Member

nemchik commented Jul 27, 2023

I've merged #339 and it seems there are no merge conflicts with this. Would you mind updating the changelog dates?

@nemchik nemchik added the awaiting-approval Stale exempt label Jul 27, 2023
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-1306d4d4-dev-cae42496e268b8419faff165b7c9ad4dd96596c3-pr-390/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-1306d4d4-dev-cae42496e268b8419faff165b7c9ad4dd96596c3-pr-390/shellcheck-result.xml

Tag Passed
amd64-2.6.0-pkg-1306d4d4-dev-cae42496e268b8419faff165b7c9ad4dd96596c3-pr-390
arm64v8-2.6.0-pkg-1306d4d4-dev-cae42496e268b8419faff165b7c9ad4dd96596c3-pr-390

@ejach
Copy link
Contributor Author

ejach commented Jul 28, 2023

I've merged #339 and it seems there are no merge conflicts with this. Would you mind updating the changelog dates?

For sure. I will get this squared away soon. Thanks.

@nemchik
Copy link
Member

nemchik commented Jul 28, 2023

Sorry, I notice now that merging #376 caused actual merge conflicts. should be fairly simple to resolve.

@ejach
Copy link
Contributor Author

ejach commented Jul 28, 2023

Sorry, I notice now that merging #376 caused actual merge conflicts. should be fairly simple to resolve.

Got the merge conflicts squared away. Please let me know if there is anything else I need to do. Thanks.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-34f2a8ff-dev-b46830f2141dc1b24f73a1425adb6cb1ac6576b7-pr-390/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-34f2a8ff-dev-b46830f2141dc1b24f73a1425adb6cb1ac6576b7-pr-390/shellcheck-result.xml

Tag Passed
amd64-2.6.0-pkg-34f2a8ff-dev-b46830f2141dc1b24f73a1425adb6cb1ac6576b7-pr-390
arm64v8-2.6.0-pkg-34f2a8ff-dev-b46830f2141dc1b24f73a1425adb6cb1ac6576b7-pr-390

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-284ad157-dev-95545829626a090d66fb5ff421412f62dcc6cd17-pr-390/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-284ad157-dev-95545829626a090d66fb5ff421412f62dcc6cd17-pr-390/shellcheck-result.xml

Tag Passed
amd64-2.6.0-pkg-284ad157-dev-95545829626a090d66fb5ff421412f62dcc6cd17-pr-390
arm64v8-2.6.0-pkg-284ad157-dev-95545829626a090d66fb5ff421412f62dcc6cd17-pr-390

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-199779c3-dev-e19a030efffafb436dbdf3ab581450a5e75538a2-pr-390/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-199779c3-dev-e19a030efffafb436dbdf3ab581450a5e75538a2-pr-390/shellcheck-result.xml

Tag Passed
amd64-2.6.0-pkg-199779c3-dev-e19a030efffafb436dbdf3ab581450a5e75538a2-pr-390
arm64v8-2.6.0-pkg-199779c3-dev-e19a030efffafb436dbdf3ab581450a5e75538a2-pr-390

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-199779c3-dev-6b7cdb26f1eb653772a32992dd1706e73e6d8e0a-pr-390/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.6.0-pkg-199779c3-dev-6b7cdb26f1eb653772a32992dd1706e73e6d8e0a-pr-390/shellcheck-result.xml

Tag Passed
amd64-2.6.0-pkg-199779c3-dev-6b7cdb26f1eb653772a32992dd1706e73e6d8e0a-pr-390
arm64v8-2.6.0-pkg-199779c3-dev-6b7cdb26f1eb653772a32992dd1706e73e6d8e0a-pr-390

@nemchik nemchik merged commit 42ccafc into linuxserver:master Aug 7, 2023
@ejach ejach deleted the certbot-dns-bunny branch August 8, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Stale exempt

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[FEAT] Bunny.net DNS Configuration

3 participants