libwacom-1.4 breaks gamepad permissions

[sbstnk]

Updating from libwacom-1.3 to libwacom-1.4 on Fedora 32 seems to have affected the permissions assigned to gamepads, resulting in those no longer working.

This is getfacl /dev/input/event8 and udevadm info /dev/input/event8 with libwacom-1.3:

# file: dev/input/event8
# owner: root
# group: input
user::rw-
user:sebastian:rw-
group::rw-
mask::rw-
other::---

P: /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/input/input50/event8
N: input/event8
L: 0
S: input/by-id/usb-Microsoft_Controller_3032363030323039343337383031-event-joystick
S: input/by-path/pci-0000:00:14.0-usb-0:2:1.0-event-joystick
E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/input/input50/event8
E: DEVNAME=/dev/input/event8
E: MAJOR=13
E: MINOR=72
E: SUBSYSTEM=input
E: USEC_INITIALIZED=101144125366
E: ID_INPUT=1
E: ID_INPUT_JOYSTICK=1
E: ID_VENDOR=Microsoft
E: ID_VENDOR_ENC=Microsoft
E: ID_VENDOR_ID=045e
E: ID_MODEL=Controller
E: ID_MODEL_ENC=Controller
E: ID_MODEL_ID=02ea
E: ID_REVISION=0301
E: ID_SERIAL=Microsoft_Controller_3032363030323039343337383031
E: ID_SERIAL_SHORT=3032363030323039343337383031
E: ID_TYPE=generic
E: ID_BUS=usb
E: ID_USB_INTERFACES=:ff47d0:
E: ID_USB_INTERFACE_NUM=00
E: ID_USB_DRIVER=xpad
E: ID_PATH=pci-0000:00:14.0-usb-0:2:1.0
E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_2_1_0
E: ID_FOR_SEAT=input-pci-0000_00_14_0-usb-0_2_1_0
E: LIBINPUT_DEVICE_GROUP=3/45e/2ea:usb-0000:00:14.0-2
E: DEVLINKS=/dev/input/by-id/usb-Microsoft_Controller_3032363030323039343337383031-event-joystick /dev/input/by-path/pci-0000:00:14.0-usb-0:2:1.0-event-joystick

And with libwacom-1.4:

# file: dev/input/event8
# owner: root
# group: input
user::rw-
group::rw-
other::---

P: /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/input/input49/event8
N: input/event8
L: 0
S: input/by-id/usb-Microsoft_Controller_3032363030323039343337383031-event-joystick
S: input/by-path/pci-0000:00:14.0-usb-0:2:1.0-event-joystick
E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/input/input49/event8
E: DEVNAME=/dev/input/event8
E: MAJOR=13
E: MINOR=72
E: SUBSYSTEM=input
E: USEC_INITIALIZED=101023588128
E: ID_INPUT=1
E: ID_VENDOR=Microsoft
E: ID_VENDOR_ENC=Microsoft
E: ID_VENDOR_ID=045e
E: ID_MODEL=Controller
E: ID_MODEL_ENC=Controller
E: ID_MODEL_ID=02ea
E: ID_REVISION=0301
E: ID_SERIAL=Microsoft_Controller_3032363030323039343337383031
E: ID_SERIAL_SHORT=3032363030323039343337383031
E: ID_TYPE=generic
E: ID_BUS=usb
E: ID_USB_INTERFACES=:ff47d0:
E: ID_USB_INTERFACE_NUM=00
E: ID_USB_DRIVER=xpad
E: ID_PATH=pci-0000:00:14.0-usb-0:2:1.0
E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_2_1_0
E: LIBINPUT_DEVICE_GROUP=3/45e/2ea:usb-0000:00:14.0-2
E: DEVLINKS=/dev/input/by-id/usb-Microsoft_Controller_3032363030323039343337383031-event-joystick /dev/input/by-path/pci-0000:00:14.0-usb-0:2:1.0-event-joystick

Notably the ID_INPUT_JOYSTICK is gone with libwacom-1.4.

[sbstnk]

I think I found the issue:

ENV{ID_INPUT_JOYSTICK}="0", ENV{ID_INPUT_JOYSTICK}=""

in 65-libwacom.rules. The first entry should do pattern matching, but is an assignment instead. This results in no gamepads/joysticks being assigned that property (or rather it being unset).