Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to README.md and README-template.md #6

Merged
merged 6 commits into from Sep 25, 2018

Conversation

andeladenaro
Copy link
Contributor

No description provided.

@tadly
Copy link
Member

tadly commented Sep 25, 2018

I spent some time playing with the README and before I merge this here a few things I would like changed.

1. Include assets in the repo

I took the liberty of creating the assets the way I want them to be added to the repository (I might revise that in the future, not sure yet).
The contents of this directory I'd like to be added in a directory called media in the root of the project.

2. Readme

For the readme I'd like a few changes which would be difficult to explain so here is the top portion the way I want it (for now) :)

Note how I changed the first heading from dups to Overview.

<p align="center">
  <img alt="dups banner" src="https://github.com/linuxwhatelse/dups/blob/master/media/dups-banner.png">
</p>
<p align="center">
  <a href="https://saythanks.io/to/tadly">
    <img alt="Say Thanks" src="https://img.shields.io/badge/say-thanks-e91e63.svg">
  </a>
  <a href="https://ci.appveyor.com/project/tadly/dups/branch/master">
    <img alt="Build status" src="https://ci.appveyor.com/api/projects/status/ia8xtstfs2bkxu8g/branch/master?svg=true">
  </a>
</p>

# Overview
dups is a simple backup utility which uses [rsync](https://rsync.samba.org/)
for the heavy lifting in the background and adds some sugar around it.  
...

I think that's all actually :)

@andeladenaro
Copy link
Contributor Author

  1. Which folder I should add the contents? I cannot find any folder named media.

  2. I think it's bit difficult to change files before we merge it. I try to copy and paste the heading in my forked repo and it will look like this.
    screen shot 2018-09-25 at 6 07 58 pm

@tadly
Copy link
Member

tadly commented Sep 25, 2018

  1. The folder does not yet exist and has to be created :)
  2. This is to be expected as the images don't yet exist in the repository

But, to be clean, let's make two PRs instead.

The new PR should only create the media folder in the projects root directory containing all the assets as mentioned above.

This PR will than update both README files after I merged the other one.

@andeladenaro
Copy link
Contributor Author

Ok, now I see. I have made the folder and add the files.

@tadly
Copy link
Member

tadly commented Sep 25, 2018

We're getting there.

Now either remove the README changes in this PR and make a new one or update both README with the changes I told you before.

@andeladenaro
Copy link
Contributor Author

Ok, I've update both README with the changes you told me before.

@tadly tadly merged commit cd5d40f into linuxwhatelse:master Sep 25, 2018
@tadly
Copy link
Member

tadly commented Sep 25, 2018

Looking good :)

Thank you very very much for your contribution. I really do appreciate it!

@tadly tadly mentioned this pull request Sep 25, 2018
@tadly
Copy link
Member

tadly commented Sep 25, 2018

Almost forgot!
Unless you don't want me to (please let me know) I'll add your name and link to your github profile to a new Credits section in README very soon.

I'm not a 100% convinced on the Credits name yet but will decide soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants