Fix SubmitSMResp unmarshalling when CommandStatus != data.ESME_ROK #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change has introduced a bug when submit_sm_resp contains a CommandStatus != data.ESME_ROK. |
linxGnu
pushed a commit
that referenced
this pull request
Nov 8, 2023
…119) Fix for #117 and #118 I don't fully understand the reason behind #113 , but that change is causing issues when submit_sm_resp returns with command_status != 0. I propose we ignore the io.EOF error when unmarshalling the message_id. I also added a test to identify this issue in future. Reminder, as per the spec: The submit_sm_resp PDU Body is not returned if the command_status field contains a non-zero value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.