Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Poetry with Conda? #170

Closed
l0b0 opened this issue Mar 1, 2023 · 3 comments
Closed

Replace Poetry with Conda? #170

l0b0 opened this issue Mar 1, 2023 · 3 comments

Comments

@l0b0
Copy link
Collaborator

l0b0 commented Mar 1, 2023

Since we basically have to use Conda now in order to install GDAL on Windows, we might want to reduce the complexity of installing the requirements by removing the need for Poetry.

Requirements:

  • A lock file with hashes for each package, equivalent to poetry.lock. This ensures that any re-release of a version (malicious or accidental) is treated as an error, and that builds are more reproducible.
  • poetry.lock and pyproject.toml should be replaced with an environment.yml.
  • Documentation files have to be updated.
  • Activating the Nix shell should be sufficient to install all the prerequisites, as it is now with poetry2nix. See for example the Nix wiki for some ideas.

Wanted features:

  • The CI jobs should be simplified.
  • Avoid Poetry Windows issues (1, 2)

Issues:

Conclusion: This would be even more of a pain to maintain than the current solution. Scrapping for now.

@l0b0 l0b0 closed this as completed Mar 12, 2023
@ameya-deshmukh
Copy link

Hi @l0b0 I see you've mentioned a lack of something like conda2nix for this issue. Do you think a tool like conda2nix would be useful for you? If so, will begin work on it :)

@l0b0
Copy link
Collaborator Author

l0b0 commented Apr 16, 2023

Hi @ameya-deshmukh, I think it's an excellent idea to build it! I think it would be very useful for the community.

That said, I probably wouldn't be able to help develop or test it until it's stable enough for production use (assuming 1+ years of multiple people developing, and at least a handful of people using it regularly). This is a work repository, it's currently the only one I'm working on which uses Conda, and while the current solution is clunky and might fail in the future if Conda and Poetry don't play nice, the current code does work.

@ameya-deshmukh
Copy link

Hi, thanks so much for the input!

Yeah for sure, long way for it to get to production, just wanted to get some inputs on whether something like that would be useful, and I think I've got my answer. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants