Log the URL used in the RESTful API request. #14

Merged
merged 1 commit into from Sep 28, 2012

Conversation

2 participants
Contributor

ashchristopher commented Jan 2, 2012

I found it useful to have access to the URL used in the request. Simple change.

Owner

dlo commented May 2, 2012

If we're going to introduce logging, we should probably have it throughout the library (and not just for the URL). Thoughts?

Contributor

ashchristopher commented May 2, 2012

Agreed - but figured this could start the dialogue =).

Contributor

ashchristopher commented Sep 28, 2012

There has been no dialogue, so will close the PR.

Owner

dlo commented Sep 28, 2012

Ah, sorry! I've been super busy with personal life stuff, don't mean to shut this down. The PR definitely has merit. I will accept it.

dlo reopened this Sep 28, 2012

@dlo dlo added a commit that referenced this pull request Sep 28, 2012

@dlo dlo Merge pull request #14 from ashchristopher/master
Log the URL used in the RESTful API request.
e757d97

@dlo dlo merged commit e757d97 into lionheart:master Sep 28, 2012

Owner

dlo commented Sep 28, 2012

I will add more logging throughout the library unless you want to do it. No pressure either way.

Contributor

ashchristopher commented Sep 28, 2012

I'll definitely toss some more logging in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment