New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force to build document before closing the stream. #7

Merged
merged 1 commit into from May 18, 2016

Conversation

Projects
None yet
2 participants
@yanntm
Member

yanntm commented May 17, 2016

As specified by Apache documentation,
"Because Axiom uses deferred parsing, the stream must be closed AFTER processing the document (unless OMElement#build() is called)"

the parse may be incomplete when the current code closes the input stream, leading to downstream exceptions when later using a large file (Colored in particular). This patch forces to finish the parse before exiting the function.

So this patches the patch of Abel, but loses some on the-fly-ness from the parser.

@lhillah lhillah merged commit b84273b into lip6:master May 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lhillah

This comment has been minimized.

Show comment
Hide comment
@lhillah

lhillah May 18, 2016

Collaborator

Merged. Sorry for the breakage in your current processing flow.

Collaborator

lhillah commented May 18, 2016

Merged. Sorry for the breakage in your current processing flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment