Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-49040 #40

Closed
wants to merge 30 commits into from
Closed

LPS-49040 #40

wants to merge 30 commits into from

Conversation

@drewbrokke
Copy link

drewbrokke commented Aug 8, 2014

Hi Tibor, this is a fix for LPS-49040 from @brunobasto.

ealonso and others added 30 commits Aug 8, 2014
@lipusz

This comment has been minimized.

Copy link
Owner

lipusz commented Aug 8, 2014

Hey Bruno, Drew,

This solution has some common points with #39. The only significant difference I can see is that you are using Layout local service to get the count, while I chose to use remote to ensure VIEW permission filtering.

Since LayoutsTreeUtil is called from the view (through the GetLayoutsAction) and from some JSPs for layouts, and the "layouts" list is also retrieved by a remote call, I would go ahead with that approach.

I will check it further on Monday.

Thanks!

@lipusz

This comment has been minimized.

Copy link
Owner

lipusz commented Aug 10, 2014

#39 (LPS-48480) will solve this with some other issues as well.
Thanks!

@lipusz lipusz closed this Aug 10, 2014
@drewbrokke drewbrokke deleted the drewbrokke:pr-7 branch Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.