Network manager recreates the tunnelendpoints if deleted #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alacuku. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/test |
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
from
44eca03
to
fa67a91
Compare
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
from
fa67a91
to
0b0b75a
Compare
|
/test |
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
3 times, most recently
from
fd88a3d
to
d4d7117
Compare
|
/test |
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
from
d4d7117
to
9d73107
Compare
|
/test |
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
from
9d73107
to
4fbba16
Compare
|
/test |
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
from
4fbba16
to
19ab554
Compare
|
/test |
|
/build |
|
/rebase |
aleoli
approved these changes
Jan 10, 2022
|
/test |
2 similar comments
|
/test |
|
/test |
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
from
19ab554
to
a44a042
Compare
|
/test |
giorio94
approved these changes
Jan 13, 2022
internal/liqonet/network-manager/tunnelendpointcreator/tunnelendpointcreator.go
Outdated
Show resolved
Hide resolved
…when changed The tunnelendpointcreator controller part of the network manager now reconciles the networkconfigs each time the tunnelendpoint associated with the given networkconfig is created/updated/deleted. No need to restart the network-manager to have the tunnelendpoint recreated if deleted.
alacuku
force-pushed
the
kcl/network-manager-reconcile-tunnelendpoint
branch
from
a44a042
to
66fb2dc
Compare
|
/test |
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tunnelendpointcreator controller part of the network manager now reconciles the networkconfigs each time the tunnelendpoint associated with the given networkconfig is created/updated/deleted. No need to restart the network-manager to have the tunnelendpoint recreated if deleted.
Fixes #(issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.