Fix Get External Address for the Auth Service #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aleoli. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
aleoli
force-pushed
the
aol/fix-service-address
branch
3 times, most recently
from
6009599
to
00b0c54
Compare
aleoli
force-pushed
the
aol/fix-service-address
branch
from
00b0c54
to
099893c
Compare
aleoli
force-pushed
the
aol/fix-service-address
branch
from
099893c
to
594bf38
Compare
aleoli
changed the title
palexster
approved these changes
Apr 6, 2021
mlavacca
approved these changes
Apr 6, 2021
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes an issue that prevents getting the correct authentication service address when exposed with a LoadBalancer service with a hostname. In addition, it implements a new mechanism to prefer external node IPs when the Auth service is exposed with a NodePort service.
How Has This Been Tested?