Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor uninstaller to support new Liqo Authentication and peering #737

Merged
merged 1 commit into from Jul 8, 2021

Conversation

palexster
Copy link
Member

Description

This PR refactors the pre-delete uninstall logic in order to be compliant with the new Liqo authentication and peering.

How Has This Been Tested?

  • E2E Tests
  • Unit Tests

@adamjensenbot
Copy link
Collaborator

Hi @palexster. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@palexster palexster changed the title [WIP] Refactor uninstaller to support new Liqo Authentication and peering Refactor uninstaller to support new Liqo Authentication and peering Jul 7, 2021
@palexster palexster force-pushed the apa/uninstaller branch 2 times, most recently from 0eb14c5 to 6c53a4e Compare July 7, 2021 20:29
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/uninstaller/deletion.go Outdated Show resolved Hide resolved
Co-authored-by: Alessandro Olivero <aleoli96@gmail.com>
@palexster palexster merged commit 90e7ef6 into master Jul 8, 2021
@palexster palexster deleted the apa/uninstaller branch July 8, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants