Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Race Condition in ResourceRequest Phase Test #844

Merged
merged 1 commit into from Aug 26, 2021

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Aug 26, 2021

Description

This pr fixes a race condition that could happen during the ResourceRequest Phase unit tests

How Has This Been Tested?

  • locally
  • on github actions

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Aug 26, 2021

/test

@aleoli aleoli marked this pull request as ready for review August 26, 2021 10:23
@aleoli aleoli force-pushed the aol/fix-resource-request-phase-test branch from 5b47917 to e346acb Compare August 26, 2021 13:23
@aleoli
Copy link
Member Author

aleoli commented Aug 26, 2021

/test

@palexster
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 26, 2021
@adamjensenbot adamjensenbot merged commit 34cb1fc into master Aug 26, 2021
@adamjensenbot adamjensenbot deleted the aol/fix-resource-request-phase-test branch August 26, 2021 13:59
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants