Remove the cluster config from network operators #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @giorio94. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/test |
giorio94
force-pushed
the
mio/cluster-config-4
branch
from
17f4e1b
to
1efecda
Compare
giorio94
force-pushed
the
mio/cluster-config-4
branch
from
1efecda
to
e025e32
Compare
|
/test |
giorio94
force-pushed
the
mio/cluster-config-4
branch
from
e025e32
to
e451111
Compare
|
/test |
giorio94
requested review from
palexster,
davidefalcone1,
aleoli and
alacuku
alacuku
approved these changes
Sep 7, 2021
palexster
approved these changes
Sep 7, 2021
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
alacuku
added a commit
that referenced
this pull request
Sep 29, 2021
…etwork manager to restart Subnets in CIDR notation can be passed to the network manager as parameters in order to prevent them to be used for remote clusters. A bug prevented the network manager to restart when networks to be reserved are passed as arguments. The bug introduced in PR #868 has been fixed. If a subnet has to be removed from the reserved networks we just remove the parameter from the network manager and restart the operator.
2 tasks
alacuku
added a commit
that referenced
this pull request
Sep 30, 2021
…etwork manager to restart Subnets in CIDR notation can be passed to the network manager as parameters in order to prevent them to be used for remote clusters. A bug prevented the network manager to restart when networks to be reserved are passed as arguments. The bug introduced in PR #868 has been fixed. If a subnet has to be removed from the reserved networks we just remove the parameter from the network manager and restart the operator.
alacuku
added a commit
that referenced
this pull request
Sep 30, 2021
…etwork manager to restart Subnets in CIDR notation can be passed to the network manager as parameters in order to prevent them to be used for remote clusters. A bug prevented the network manager to restart when networks to be reserved are passed as arguments. The bug introduced in PR #868 has been fixed. If a subnet has to be removed from the reserved networks we just remove the parameter from the network manager and restart the operator.
alacuku
added a commit
that referenced
this pull request
Oct 5, 2021
…etwork manager to restart Subnets in CIDR notation can be passed to the network manager as parameters in order to prevent them to be used for remote clusters. A bug prevented the network manager to restart when networks to be reserved are passed as arguments. The bug introduced in PR #868 has been fixed. If a subnet has to be removed from the reserved networks we just remove the parameter from the network manager and restart the operator.
adamjensenbot
pushed a commit
that referenced
this pull request
Oct 6, 2021
…etwork manager to restart Subnets in CIDR notation can be passed to the network manager as parameters in order to prevent them to be used for remote clusters. A bug prevented the network manager to restart when networks to be reserved are passed as arguments. The bug introduced in PR #868 has been fixed. If a subnet has to be removed from the reserved networks we just remove the parameter from the network manager and restart the operator.
aleoli
pushed a commit
to aleoli/liqo
that referenced
this pull request
Oct 11, 2021
…ed the network manager to restart Subnets in CIDR notation can be passed to the network manager as parameters in order to prevent them to be used for remote clusters. A bug prevented the network manager to restart when networks to be reserved are passed as arguments. The bug introduced in PR liqotech#868 has been fixed. If a subnet has to be removed from the reserved networks we just remove the parameter from the network manager and restart the operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes of the cluster config parameters from the network operators and replaces them with appropriate command line flags.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.