Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header to golang files #875

Merged
merged 1 commit into from Sep 9, 2021
Merged

Add license header to golang files #875

merged 1 commit into from Sep 9, 2021

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Sep 8, 2021

Description

This PR adds a linting check to ensure a consistent license header is present in golang files, and adds it to all files.
@reviewers Probably the biggest PR ever, but an easy one. Either yes, or no :)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Checking the outcome of golangci-lint

@giorio94 giorio94 requested a review from a team September 8, 2021 17:25
@adamjensenbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

giorio94 commented Sep 8, 2021

/test

@palexster
Copy link
Member

/rebase test=true

@giorio94
Copy link
Member Author

giorio94 commented Sep 9, 2021

/test

@palexster
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 9, 2021
@adamjensenbot adamjensenbot merged commit c37caa3 into master Sep 9, 2021
@adamjensenbot adamjensenbot deleted the mio/license branch September 9, 2021 07:58
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants