Virtual kubelet: working queue-based reflection manager #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
1 similar comment
|
/test |
giorio94
force-pushed
the
mio/reflection-manager
branch
from
d72110d
to
a9c8d18
Compare
palexster
approved these changes
Oct 6, 2021
|
/hold Giving precedence to #933 to limit conflicts |
giorio94
force-pushed
the
mio/reflection-manager
branch
from
a9c8d18
to
6569f72
Compare
|
/unhold #933 has been merged |
|
/test |
alacuku
approved these changes
Oct 12, 2021
|
/rebase test=true |
adamjensenbot
force-pushed
the
mio/reflection-manager
branch
from
6569f72
to
c5c1404
Compare
|
/test |
1 similar comment
|
/test |
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces in the virtual kubelet a reflection manager leveraging working queues, for better resiliency and improved performance. Currently, only the management/generic logic is introduced, while future PRs will implement the different reflectors.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.