Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liqoctl offload namespace #980

Merged
merged 1 commit into from Nov 4, 2021
Merged

liqoctl offload namespace #980

merged 1 commit into from Nov 4, 2021

Conversation

palexster
Copy link
Member

Description

This PR introduces the liqoctl offload command to configure the NamespaceOffloading resource for a given namespace.

How Has This Been Tested?

  • Unit Tests

@adamjensenbot
Copy link
Collaborator

Hi @palexster. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@palexster palexster force-pushed the apa/liqoctl-offload branch 2 times, most recently from 2d2ac58 to 3aab41e Compare November 3, 2021 16:06
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Nov 3, 2021
@palexster
Copy link
Member Author

/test

@palexster palexster requested review from giorio94, aleoli, alacuku and Andreagit97 and removed request for giorio94 November 3, 2021 16:24
Andreagit97
Andreagit97 approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems good to me, perhaps I would specify in the "long command help" that labels (both with whitelisting and blacklisting policies) are all combined in logical OR, using an example to make it easier.

pkg/liqoctl/offload/namespace.go Outdated Show resolved Hide resolved
@palexster palexster force-pushed the apa/liqoctl-offload branch 4 times, most recently from 810a61a to 2ff66f3 Compare November 4, 2021 10:08
@palexster
Copy link
Member Author

/test

@palexster
Copy link
Member Author

/test

@palexster palexster marked this pull request as ready for review November 4, 2021 10:58
@palexster
Copy link
Member Author

/test

@palexster
Copy link
Member Author

/test

aleoli
aleoli approved these changes Nov 4, 2021
View reviewed changes
pkg/liqoctl/offload/namespace_test.go Outdated Show resolved Hide resolved
@palexster
Add liqoctl offload command
bcab9c0 
This commit introduces the liqoctl offload namespace command to
selectively offload a namespace.
@palexster
Copy link
Member Author

/test

@palexster
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 4, 2021
@adamjensenbot adamjensenbot merged commit ae47d0b into liqotech:master Nov 4, 2021
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@aleoli aleoli aleoli approved these changes

@alacuku alacuku Awaiting requested review from alacuku

@giorio94 giorio94 Awaiting requested review from giorio94

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@palexster @adamjensenbot @aleoli @Andreagit97