From 1d04d4b3c98a50b2f5e54a7857c39346ed232699 Mon Sep 17 00:00:00 2001 From: Nathan Voxland Date: Mon, 13 Dec 2021 16:47:32 -0600 Subject: [PATCH 1/3] Correctly handle cacheSize for mariadb --- .../liquibase/sqlgenerator/core/CreateSequenceGenerator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java index 80472085db7..8c041a0bd8a 100644 --- a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java +++ b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java @@ -92,7 +92,7 @@ public Sql[] generateSql(CreateSequenceStatement statement, Database database, S } if (statement.getCacheSize() != null) { - if (database instanceof OracleDatabase || database instanceof Db2zDatabase || database instanceof PostgresDatabase) { + if (database instanceof OracleDatabase || database instanceof Db2zDatabase || database instanceof PostgresDatabase || database instanceof MariaDBDatabase) { if (BigInteger.ZERO.equals(statement.getCacheSize())) { if (database instanceof OracleDatabase) { queryStringBuilder.append(" NOCACHE "); From 5a849ef2abb3100ec175117c43264614224c4b24 Mon Sep 17 00:00:00 2001 From: Nathan Voxland Date: Mon, 13 Dec 2021 16:54:31 -0600 Subject: [PATCH 2/3] Correctly handle cacheSize for mariadb --- .../liquibase/sqlgenerator/core/AlterSequenceGenerator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java index ccdf33cc5e4..220062d10fb 100644 --- a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java +++ b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AlterSequenceGenerator.java @@ -72,7 +72,7 @@ public Sql[] generateSql(AlterSequenceStatement statement, Database database, Sq } } - if ((statement.getCacheSize() != null) && (database instanceof OracleDatabase || database instanceof PostgresDatabase)) { + if ((statement.getCacheSize() != null) && (database instanceof OracleDatabase || database instanceof PostgresDatabase || database instanceof MariaDBDatabase)) { if (statement.getCacheSize().equals(BigInteger.ZERO)) { buffer.append(" NOCACHE "); } else { From 4c93822b9852909ad6d7a98bbba1335b55a83e77 Mon Sep 17 00:00:00 2001 From: Nathan Voxland Date: Mon, 3 Jan 2022 13:21:43 -0600 Subject: [PATCH 3/3] Handle cacheSize=0 for createSequence on mariadb --- .../liquibase/sqlgenerator/core/CreateSequenceGenerator.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java index 8c041a0bd8a..f383e4955b4 100644 --- a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java +++ b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/CreateSequenceGenerator.java @@ -96,6 +96,8 @@ public Sql[] generateSql(CreateSequenceStatement statement, Database database, S if (BigInteger.ZERO.equals(statement.getCacheSize())) { if (database instanceof OracleDatabase) { queryStringBuilder.append(" NOCACHE "); + } else if (database instanceof MariaDBDatabase) { + queryStringBuilder.append(" CACHE 0"); } } else { queryStringBuilder.append(" CACHE ").append(statement.getCacheSize());