-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSGi data in MANIFEST.MF is incorrect in version 4.7.0 #2361
Comments
I can see the same problem. Are there any special "things" when a release build is created? I mean ManifestReversion.java where I think the wrong version is set. |
thanks @driessamyn for the detail here -- checking on this |
The updates to the MANIFEST.MF happens only during a release or draft release build. However, we cannot get the fix into the draft release until this PR is merged. Liquibase Internal QA has an issue assigned to ensure we validate the MANIFEST.MF is updated when we have a release candidate. |
In https://github.com/liquibase/liquibase/releases/download/v4.8.0/liquibase-4.8.0.jar this issue is still present: Versions are of form "[4.8.0,1) with wrong upper bound 1 and missing right quotation mark. |
@nvoxland, the fix addressed only the first issue @sf-bit described. This is the section that we missed:
Should we reopen this issue? CC @kataggart |
@XDelphiGrl yes, thanks, doing it now! |
Sorry, I missed that issue with the quoting and just fixed up the missed SNAPSHOT version. #2573 will address the quoting issue. |
I missed it too, @nvoxland. Thanks for new PR! |
Re-opening to test at release time |
4.8.0 available at maven cental has followin issue: After inspecting the JAR you can see that
|
I checked the MANIFEST.MF file for the wrapping up 4.9.0 release and the quoting is correct in the final build. I'm going to close this issue as fixed in 4.8.0 since it was about the problems in the MANIFEST.MF file, but I'll open a new ticket for what you found @ktor . |
I think the issue needs to be re-opened as the problem is still the same. I did a manual fixup of the manifest to prove the jar otherwise work (copy pasted below). Any chance we could get a patch out with the fixed manifest? If it is helpful, I can provide an OSGi test that would surface this issue, but as you edit the manifest post publication, it would need to be separate from the main build I'm guessing?
|
I believe the problem is here:
|
@driessamyn @ktor we are fixing this here #2672 (comment) and are actually looking for user verification on the new format if you have a moment that issue has a copy of the new MANIFEST.MF. We'd love for you and others who were impacted by this to take a look and verify it works before we do the full new release. Thanks!! |
@driessamyn and @ktor could you check if the attached jar (renamed as a .zip for github reasons) works correctly? We're getting ready to release that, but my understanding of OSGi is tenuous and some additional verification would be a huge help. Thanks! |
I ran a test with the attached and it worked. I could create a standalone OSGi test that you may be able to integrate with your pipeline if you think that would be useful? |
Thank you! 👌 |
Great, thanks for the double check @driessamyn and @ktor! Yes, @driessamyn if you would be able to point us to how we could improve our OSGi tests, that would be very helpful. Nathan |
Environment
Liquibase Version: 4.7.0
Liquibase Integration & Version: liquibase-core
Liquibase Extension(s) & Version: n/a
Database Vendor & Version: n/a
Operating System Type & Version: MacOs, openjdk 11.0.11 2021-04-20 LTS
Description
The
MANIFEST.MF
file insideliquibase-core-4.7.0.jar
is not valid.Something around versioning seems to have gone wrong.
Specifically:
Bundle-Version: 0.0.0.SNAPSHOT
should beBundle-Version: 4.7.0
Liquibase packages inside the
Import-Package
list have incorrect version definition. E.g....,liquibase.change;resolution:=optional;version="[4.7.0,1),...
the version specification should be
[4.7,5)
and there is an issue with quotation marks as the opening quotes afterversion=
don't get closed.A locally compiled earlier version has this instead:
`...liquibase.change;resolution:=optional;version="[4.5,5)",...
This means the bundle cannot be resolved. Trying do to so using bnd shows an error like this:
Steps To Reproduce
To see the contents of the file:
liquibase-core-4.7.0.jar
from Maven Centralliquibase-core-4.7.0.jar
META-INF/MANIFEST.MF
Loading the resolution issue:
Actual Behavior
Expected/Desired Behavior
The text was updated successfully, but these errors were encountered: