Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation #1002

Open
wants to merge 4 commits into
base: 3.8.x
from
Open

Updated documentation #1002

wants to merge 4 commits into from

Conversation

@b-gyula
Copy link

b-gyula commented Feb 21, 2020

  • Added description for

    • addAutoIncrement / generationType, defaultOnNull, startWith, incrementBy
    • addForeignKeyConstraint / referencedTableCatalogName, referencedTableSchemaName, baseTableSchemaName, baseTableCatalogName
    • addUniqueConstraint, createIndex / clustered
    • alterSequence / sequenceName, cycle
    • createProcedure / procedureName, replaceIfExists, procedureText
    • createTable / remarks + tablespace
    • createView / remarks
    • dropAllForeignKeyConstraints / baseTableSchemaName, baseTableName
    • dropTable / cascadeConstraints
    • load[Update]Date / usePreparedStatements, commentLineStartsWith, separator, quotchar
    • setTableRemarks / remarks
    • setColumnRemarks / remarks
    • sql / sql
    • update + insert / where
  • Fields marked required for ALL

    • insert, update / tableName, columns
    • dropTabe / tableName
    • output / message
    • tagDatabase / tag made
  • Minor typo fixes

  • Changed examples for dbms to be consistent with the samples on the website

Findings

  • createProcedure / comments defined as comment in te XSD so it's never populated -> Removed from documentation (changeSet can have comment child)
  • sql / comment read, but never used -> Should be removed also (changeSet can have comment child)
b-gyula added 4 commits Jan 9, 2020
Mergeback
Mergeback
- Added description for
  - addAutoIncrement / generationType, defaultOnNull, startWith, incrementBy
  - addForeignKeyConstraint / referencedTableCatalogName, referencedTableSchemaName, baseTableSchemaName, baseTableCatalogName
  - addUniqueConstraint, createIndex / clustered
  - alterSequence / sequenceName, cycle
  - createProcedure / procedureName, replaceIfExists, procedureText
  - createTable / remarks + tablespace
  - createView / remarks
  - dropAllForeignKeyConstraints / baseTableSchemaName, baseTableName
  - dropTable / cascadeConstraints
  - load[Update]Date / usePreparedStatements, commentLineStartsWith, separator, quotchar
  - setTableRemarks / remarks
  - setColumnRemarks / remarks
  - sql / sql
  - update + insert / where

- Fields marked required for ALL
  - insert, update / tableName, columns
  - dropTabe / tableName
  - output / message
  - tagDatabase / tag made

- Minor typo fixes
- Changed examples for `dbms` to be consistens with the samples on the website
@datical-jenkins datical-jenkins changed the title Updated documentation LB-12 ⁃ Updated documentation Mar 4, 2020
@datical-jenkins datical-jenkins changed the title LB-12 ⁃ Updated documentation Updated documentation Mar 5, 2020
@SteveDonie SteveDonie added this to the 4.0 milestone Mar 27, 2020
@mariochampion

This comment has been minimized.

Copy link

mariochampion commented Mar 31, 2020

hey @SteveDonie, i want to add this to the next sprint. Can you do the review @nvoxland?

Copy link
Contributor

mccormickc left a comment

These changes look good.

@mariochampion

This comment has been minimized.

Copy link

mariochampion commented Apr 1, 2020

hey @SteveDonie -- as we are about to do end-to-end for 3.8.9, i would say we should merge this AFTER that. so that it goes into 3.8.10.

I think QA and @nvoxland will need to weigh in for final approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.