Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set Bundle-Version in META-INF on release #2505

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Feb 8, 2022

Description

The in-development code always builds as version "0.0.0" and as part of the release process we replace the metadata that stores that placeholder version with the correct version. There are several places where that needs to be updated, including a Bundle-Version flag in META-INF/MANIFEST.MF, and that version was not updated correctly.

This fixes the logic for that, and also adds a check to the re-version.sh script to grep for 0-SNAPSHOT and 0.0.0.SNAPSHOT strings to catch any other problem spots that might get lost.

Fixes #2361

@nvoxland nvoxland merged commit f33bf1d into master Feb 9, 2022
@nvoxland nvoxland deleted the osgi-versioning-fix branch February 9, 2022 15:53
mkdir -p $workdir/test
unzip -q $outdir/*.jar -d $workdir/test

if grep -rl "0-SNAPSHOT" $workdir/test; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that we have this test, @nvoxland. Does this run as part of the release build, or is it something we need to run manually? If it is manual, let's add it to our internal release documentation.

@nvoxland nvoxland added this to the v4.8.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSGi data in MANIFEST.MF is incorrect in version 4.7.0
3 participants